Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight for in tests #505

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Highlight for in tests #505

wants to merge 2 commits into from

Conversation

EBatTiVo
Copy link
Contributor

Accompaniment for #504.

Tests for highlighting the "in" keyword in a for statement. The test passes, but it should be failing: The color annotations are not being picked up by the annotator test functions in CodeInsightTestFixture. I've posted this test so that a)somebody else can take a look and tell me what I'm missing; b) I can remember that I have to revisit this issue.

@eliasku
Copy link
Contributor

eliasku commented Oct 19, 2016

Also looks good. I wonder if we could add import .. in/as .. checking as well

@EBatTiVo
Copy link
Contributor Author

The trouble with this one is that the tests pass when they shouldn't (because the compare file doesn't have any annotations in it yet). Therefore, the annotations are not being picked up by the underlying testHighlighting. I posted this mostly to find out if anybody else [was interested and] had any other ideas about how to test colorization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants