Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI elements #42

Closed
wants to merge 12 commits into from
Closed

Update UI elements #42

wants to merge 12 commits into from

Conversation

andburn
Copy link
Member

@andburn andburn commented Feb 25, 2016

Mainly adding Hero images for portrait, weapon, hero power, and graphics for minion state.
I added the svg clip paths into the index.html, but I guess they'll have to be moved (didn't include page reference fix for firefox into url() in the css either).
Also, refactored the various art components and moved them to their own directory.

Elements:


Points for me to address:

  • move the hardcoded cardArtUrl into a property
  • optimize the images
  • fix secrets (not aligned properly)

@beheh
Copy link
Collaborator

beheh commented Feb 25, 2016

Wow thanks, awesome! Looking into this.

Andrew Burnett added 3 commits February 25, 2016 20:50
Secrets are currently displayed in row along the top of the hero frame. They need to be aligned around the frame in the future, somehow.
@beheh
Copy link
Collaborator

beheh commented Feb 27, 2016

Landed.

@beheh beheh closed this Feb 27, 2016
This was referenced Feb 27, 2016
@andburn andburn deleted the update_ui branch March 1, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants