Skip to content

Commit

Permalink
fix typo culomb -> coulomb
Browse files Browse the repository at this point in the history
  • Loading branch information
HelgeGehring committed Sep 15, 2023
1 parent c9c2c21 commit bb49932
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/_toc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ parts:
- file: photonics/examples/metal_heater_phase_shifter.py
- file: photonics/examples/metal_heater_phase_shifter_transient.py
- file: photonics/examples/si_heater_phase_shifter.py
- file: photonics/examples/culomb.py
- file: photonics/examples/coulomb.py
- file: photonics/examples/leaky_mode.py
- file: photonics/examples/bragg_filter.py
- file: photonics/examples/grating_coupler.py
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from skfem.io import from_meshio
from tqdm import tqdm

from femwell.culomb import solve_coulomb
from femwell.coulomb import solve_coulomb
from femwell.maxwell.waveguide import compute_modes
from femwell.mesh import mesh_from_OrderedDict

Expand Down
File renamed without changes.

2 comments on commit bb49932

@lukasc-ubc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HelgeGehring @joamatab
This is a good fix, but the problem is that it breaks code that students are using in my course. It would be nice if changes like this were made in a way that was backwards compatible.

@HelgeGehring
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasc-ubc ups, sorry, I thought as I directly edited it after you mentioned it it would have been fine for you :/
I've added backward comparability until the end of the year in c33f4c7 which raises a warning, next year it'll raise an exception and will be removed eventually.
New version is in pypi for everyone installing it now :)

Please sign in to comment.