-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c9c2c21
commit bb49932
Showing
3 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
bb49932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HelgeGehring @joamatab
This is a good fix, but the problem is that it breaks code that students are using in my course. It would be nice if changes like this were made in a way that was backwards compatible.
bb49932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasc-ubc ups, sorry, I thought as I directly edited it after you mentioned it it would have been fine for you :/
I've added backward comparability until the end of the year in c33f4c7 which raises a warning, next year it'll raise an exception and will be removed eventually.
New version is in pypi for everyone installing it now :)