Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for reproducibility, failed builds, and CI. More hrrr tests, sh… #17

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

HelinWei-NOAA
Copy link
Owner

…orter rap&hrrr forecast lengths. (ufs-community#1257)

  • Temporarily add tests/rt_rap_decomp.conf

  • Enable test regional_spp_sppt_shum_skeb GNU, increase wallclock time to 30 minutes

  • Revert changes to test regional_spp_sppt_shum_skeb, remove from rt_gnu.conf

  • Add cpld control noaero nowave test to rt_gnu.conf for CI on AWS

  • Add compilation test of moninshoc.meta

  • Modify cpld_control_run.IN to conditionally copy wave restart file.

  • add all variants of rap_control and hrrr_control tests

  • Reduce rap&hrrr test runtime from 24 hours to 12 hours

  • Change cpld_control_c96_noaero_p8 to cpld_control_nowave_noaero_p8

  • Add noaero & nowave_noaero tests (3 of them) to rt.conf

  • add regional_3km_decomp test

  • use noaaemc docker hub account instead of MInsukJi's personal account for input data

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

…orter rap&hrrr forecast lengths. (#1257)

* Temporarily add tests/rt_rap_decomp.conf

* Enable test regional_spp_sppt_shum_skeb GNU, increase wallclock time to 30 minutes

* Revert changes to test regional_spp_sppt_shum_skeb, remove from rt_gnu.conf

* Add cpld control noaero nowave test to rt_gnu.conf for CI on AWS

* Add compilation test of moninshoc.meta

* Modify cpld_control_run.IN to conditionally copy wave restart file. 

* add all variants of rap_control and hrrr_control tests

* Reduce rap&hrrr test runtime from 24 hours to 12 hours

* Change cpld_control_c96_noaero_p8 to cpld_control_nowave_noaero_p8

* Add noaero & nowave_noaero tests (3 of them) to rt.conf

* add regional_3km_decomp test

* use noaaemc docker hub account instead of MInsukJi's personal account for input data
@HelinWei-NOAA HelinWei-NOAA merged commit beef7f2 into HelinWei-NOAA:NoahMP_p8c_mynn Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants