-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCEE setting submenu lacking back button and header text #640
Comments
WFM
Related: #613 |
This comment was marked as outdated.
This comment was marked as outdated.
Relevant PRs: I guess it has been deactivated here: ec0660e#diff-de7525ef2b31d51f2f9a717ec1c5ce00795b546dd348b81318d6d5b07e794ab2 |
Thanks for that research @mcliquid, it seems it is still unfixed in current master 38fce28 then, so this issue should remain open:
|
@mnalis I have re-added the relevant changes locally and cannot find any issues. The implementation works perfectly for me. |
The main issue is that this feature keeps creating merge conflicts, and I don't want to spend even more time on merging upstream just for an (in my opinion) irrelevant extra. |
Also it would only be temporary, until SCEE settings screens are migrated to compose. |
It was fixed by PR #668; but see comments in #668 (comment) |
SCEE 59.0-alpha2 on Android 14 on a Motorola device.
The SCEE specific setting submenus have no back icon on the top left:
Note: The first "row" is correctly blank in the screenshot as it is covered by android menu.
The text was updated successfully, but these errors were encountered: