SCEE setting submenu lacking back button and header text

[HolgerJeromin]

SCEE 59.0-alpha2 on Android 14 on a Motorola device.

The SCEE specific setting submenus have no back icon on the top left:

Note: The first "row" is correctly blank in the screenshot as it is covered by android menu.

[mnalis]

I can confirm missing back button even on SCEE 58.2 on my Android 14 (Samsung Galaxy S23+), both with navigation buttons and with gesture mode:

[rusty-snake]

WFM

• SCEE 58.22
• AOSP 14 QPR3
• Gesture Navigation

Related: #613

[mnalis]

On Android 14, Xiaomi Redmi Note 13, it is broken in 58.2 and 59.0-alpha2:

but works in 58.21 and 58.22 :

So I guess it was fixed somewhere in between, but have not made it into v59.0-alpha2 (and there have been no further SCEE releases after alpha2 which include it, and latest SCEE master fails to build so can't test it there easily).

[mcliquid]

Relevant PRs:

• add title on fragment scee #577
• Fix: add title on fragment scee #596

I guess it has been deactivated here: ec0660e#diff-de7525ef2b31d51f2f9a717ec1c5ce00795b546dd348b81318d6d5b07e794ab2

[mnalis]

I guess it has been deactivated here: ec0660e#diff-de7525ef2b31d51f2f9a717ec1c5ce00795b546dd348b81318d6d5b07e794ab2

Thanks for that research @mcliquid, it seems it is still unfixed in current master 38fce28 then, so this issue should remain open:

% fgrep -r setUpToolbarTitleAndIcon
fgrep -r setUpToolbarTitleAndIcon
DataManagementSettingsFragment.kt://            setUpToolbarTitleAndIcon(this)
DisplaySettingsFragment.kt://            setUpToolbarTitleAndIcon(this)
QuestsSettingsFragment.kt://            setUpToolbarTitleAndIcon(this)
UiSettingsFragment.kt://            setUpToolbarTitleAndIcon(this)
NoteSettingsFragment.kt://            setUpToolbarTitleAndIcon(this)

[mcliquid]

@mnalis I have re-added the relevant changes locally and cannot find any issues. The implementation works perfectly for me.
@Helium314 any reasons against these changes?

[Helium314]

The main issue is that this feature keeps creating merge conflicts, and I don't want to spend even more time on merging upstream just for an (in my opinion) irrelevant extra.

[Helium314]

Also it would only be temporary, until SCEE settings screens are migrated to compose.

[mnalis]

It was fixed by PR #668; but see comments in #668 (comment)