Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : add navigation icon + title #668

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ravenfeld
Copy link

I noticed a difference between the SC and SCEE screens.
It's missing :
the navigation icon
the title

By the way, I've removed the unnecessary spacing provided by PreferenceScreen.

Screenshot_20240929_074152

@mnalis
Copy link
Collaborator

mnalis commented Sep 29, 2024

Have you seen #640 (comment) (and below)?

@Helium314
Copy link
Owner

Are you 100% sure I will not have more issues when merging upstream? This happend already 3 times in the past months, and dealing with this over and over again simply seems like a waste of time.

@ravenfeld
Copy link
Author

I didn't see the way out, sorry.
I don't know exactly what problems you had with the fusion.
So to solve the merging problem you don't have to put the fragment extension in an SC file, you can move it and make a FragmentExtScee.kt file.

After that, the best thing to do is to compose them as you mentioned in the issue.

@Helium314
Copy link
Owner

So to solve the merging problem you don't have to put the fragment extension in an SC file, you can move it and make a FragmentExtScee.kt file.

But this is still time I have to spend on this temporary fix, instead of just working on other things. And I notice how the time I can / want to spend on SCEE is reducing recently, now that it doesn't work any more on my main phone.

@ravenfeld
Copy link
Author

ravenfeld commented Oct 1, 2024

Yes, it's temporary, because for me it's time to switch to compose.

What's wrong with your phone?
Maybe I can help you fix it.

@Helium314
Copy link
Owner

What's wrong with your phone?

See maplibre/maplibre-native#2206
I doubt you can help... either with MapLibre, or with convincing some phone manufacturer to produce some reasonable replacement for S4 Mini.

Anyway, so I'll give this one more try, but if I run into merge conflicts again because of the title, I'm going to remove it and will not accept another PR for this.

@Helium314 Helium314 merged commit 53c564d into Helium314:modified Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants