Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EXP modifiers to match aegis modifiers calclution. #1328

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fix EXP modifiers to match aegis modifiers calclution. #1328

merged 1 commit into from
Jul 1, 2016

Conversation

hemagx
Copy link
Contributor

@hemagx hemagx commented Jun 28, 2016 •
edited by MishimaHaruna
Loading

  • Now Renewal Level Penalty being calculated in pc_calcexp only
  • Now Guild Tax is being paid after experience modifiers and not before
  • Now Experience modifiers being calculated in right way as in aegis (Race modifiers -> PK modifiers -> Premium modifiers -> Buff modifiers)

This change is Reviewable

@hemagx hemagx added the status:inprogress Issue is being worked on / the pull request is still a WIP label Jun 28, 2016
@hemagx
Fix EXP modifiers to match aegis modifiers calclution.
ff75470 
- Now Renewal Level Penalty being calculated in pc_calcexp only
- Now Guild Tax is being paid after experience modifiers and not before
- Now Experience modifiers being calculated in right way as in aegis (Race modifiers -> PK modifiers -> Premium modifiers -> Buff modifiers)
@MishimaHaruna MishimaHaruna added status:code-review Awaiting code review and removed status:inprogress Issue is being worked on / the pull request is still a WIP labels Jul 1, 2016
@MishimaHaruna
Copy link
Member

:lgtm:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@MishimaHaruna MishimaHaruna merged commit f3ca547 into master Jul 1, 2016
@MishimaHaruna MishimaHaruna deleted the exp_fixes branch July 1, 2016 10:56
@MishimaHaruna MishimaHaruna removed the status:code-review Awaiting code review label Jul 1, 2016
@guilherme-gm guilherme-gm mentioned this pull request Feb 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hemagx @MishimaHaruna