Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crit not always being 0.33 crit per luk but 0.3 in some cases #3252

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix crit not always being 0.33 crit per luk but 0.3 in some cases #3252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/map/status.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3201,7 +3201,9 @@ static void status_calc_bl_main(struct block_list *bl, /*enum scb_flag*/int flag
if (st->luk == bst->luk) {
st->cri = status->calc_critical(bl, sc, bst->cri, true);
} else {
st->cri = status->calc_critical(bl, sc, bst->cri + 3*(st->luk - bst->luk), true);
// supposedly for Renewal some say it might be 0.3 crit per luk instead of 0.33 crit per luk as here.
// The behavior here is also identical to episode 14.0, can't verify this for later versions of Aegis.
st->cri = status->calc_critical(bl, sc, bst->cri - (bst->luk * 10 / 3) + (st->luk * 10 / 3), true);
}
if (battle_config.show_katar_crit_bonus && bl->type == BL_PC && BL_UCAST(BL_PC, bl)->weapontype == W_KATAR) {
st->cri *= 2;
Expand Down Expand Up @@ -3860,7 +3862,7 @@ static void status_calc_misc(struct block_list *bl, struct status_data *st, int
#endif // RENEWAL

if ( bl->type&battle_config.enable_critical )
st->cri += 10 + (st->luk * 10 / 3); //(every 1 luk = +0.3 critical)
st->cri += 10 + (st->luk * 10 / 3); // (every 1 luk = +0.33 critical -> 3 luk = +1 critical)
else
st->cri = 0;

Expand Down
Loading