Fix previously plagiarized skill re-appearing after relog, when removed prior #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Ensure that on relog the previously removed plagiarized skill doesn't get re-added.
This was due to failure to clear the remembered cloneskill script variables and such.
As by the comment
[Aegis] can't overwrite skill of higher level, but will still remove previously copied skill.this is official behavior, that if you had a plagiarized spell, something would attack you with for example Envenom 3, when you have Envenom 10, you'd then lose the plagiarized spell but not have your higher level Envenom overwritten.That being said I may consider changing it so that if it tries to copy the same level nothing happens. Or re-check if in Aegis this really will result in the removal as well, in case I missed the == case.
Issues addressed: None