Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

单独兼容打开网址 minecraft:// #3999

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

JingHai-Lingyun
Copy link
Collaborator

@JingHai-Lingyun JingHai-Lingyun commented Jun 10, 2024

仅对 minecraft:// 做了单独处理,其他的还是原来的规则
fix #3985

@allMagicNB
Copy link
Contributor

有问题,如果我只指定 minecraft 呢?

@JingHai-Lingyun
Copy link
Collaborator Author

JingHai-Lingyun commented Jun 10, 2024

只写 minecraft 在 ModEvent 那边就拦掉了

Case "打开网页"
Data(0) = Data(0).Replace("\", "/")
If Not Data(0).Contains("://") OrElse Data(0).StartsWithF("file", True) Then '为了支持更多协议(#2200)
MyMsgBox("EventData 必须为一个网址。" & vbCrLf & "如果想要启动程序,请将 EventType 改为 打开文件。", "事件执行失败")
Exit Sub
End If
Hint("正在开启中,请稍候……")
OpenWebsite(Data(0))

现在兼容了原来的写法,在这个合并之后 MFn233 的主页可以正常用

@JingHai-Lingyun JingHai-Lingyun added the 等待确认 已经过社区确认,等待开发者确认 label Jun 10, 2024
避免有人传了点别的东西进去,现在只有 `minecraft://` 会单独处理
@allMagicNB
Copy link
Contributor

如果我给 minecraft:// 后边加点参数呢?

@JingHai-Lingyun
Copy link
Collaborator Author

我一会再改改吧

现在如果给 URL Scheme 传参也能接受了
@JingHai-Lingyun
Copy link
Collaborator Author

根据 Wiki 上的记载 现在兼容按照指定格式传参进去了

@LTCatt LTCatt added 等待提交者 需要提交者补充信息或进行操作 and removed 等待确认 已经过社区确认,等待开发者确认 labels Jun 10, 2024
@JingHai-Lingyun JingHai-Lingyun added 等待确认 已经过社区确认,等待开发者确认 and removed 等待提交者 需要提交者补充信息或进行操作 labels Jun 14, 2024
@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 🟨 中 优先度:中 and removed 等待确认 已经过社区确认,等待开发者确认 labels Jun 14, 2024
@LTCatt LTCatt merged commit fec3415 into Hex-Dragon:main Jul 1, 2024
5 checks passed
@Deep-Dark-Forest Deep-Dark-Forest added 完成 已被处理,将在下次更新之后生效 and removed 处理中 开发者正在调查或处理该项 labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
· Bug 完成 已被处理,将在下次更新之后生效 🟨 中 优先度:中
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL打开基岩版的功能寄了?
5 participants