-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quilt 支持 #4214
base: main
Are you sure you want to change the base?
Quilt 支持 #4214
Conversation
refactor: 重新整了下 Quilt,但是还没完工
Please have a test on features related, such as modpack installing, auto installing, etc. Appreciate! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fix: 疑似一些正则错误
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Plain Craft Launcher 2/Pages/PageDownload/PageDownloadQuilt.xaml.vb
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
草,没切分支( |
我在想一个东西……就是说一部分模组在使用QFAPI加QSL的搭配的时候会无法使用,于是就会在QUILT下使用FABRIC API |
并且在同时选择了quilt和optifine之后…… |
If OptiFabric does not support running with Quilt, it seems that OptiFine must be disabled after selecting Quilt Loader. |
需要确认一下 OptiFabric 和 Quilt 的兼容情况 |
Chocohead/OptiFabric#847 (comment) It seems that there is no support yet. |
那么就只能是先暂时禁用 |
This comment was marked as duplicate.
This comment was marked as duplicate.
我堆了个 Pre-Release Branch 用来合并测试,先看看( |
Plain Craft Launcher 2/Pages/PageDownload/PageDownloadInstall.xaml.vb
Outdated
Show resolved
Hide resolved
fix: 错误地显示部分快照版支持 Quilt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now selecting 1.14
no longer crashes. 👍
No other issues have been found so far. Waiting for others’ opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it happens... Wait for LTCatt. I have no computer at my hands right now. |
I would like to continue discussing the possibilities of this feature. Strictly speaking, Quilt is currently a soft-fork of Fabric, without special circumstances, Fabric mods can usually be loaded happily using Quilt. Unlike NeoForge, they became a hard-fork starting in 20.2 and are officially no longer compatible with MinecraftForge. Conversely, unless some mod uses mechanisms unique to Quilt, it can generally be loaded in both Fabric and Quilt. Someone raised a similar question a month ago, and the Quilt moderator said that they would not give up compatibility with Fabric in the short term. Are there any plans about ending compatibility for Fabric? - Quilt / Development - QuiltMC I think this feature can be implemented. However, considering that Fabric API and QFAPI may cause conflicts, you may wish to refer to HMCL’s approach. In the current HMCL, if you choose either Fabric API or QFAPI/QSL, you are not allowed to choose the other one. |
In my opinion, QSL / QFAPI is designed specially for Quilt, and it can replace Fabric API, so I didn't let Fabric API appear after you have selected Quilt. |
有一些 Minecraft 版本 QFAPI 不支持或者 QFAPI 更新速度较慢,这个时候可以用 Fabric API 来替代 |
好的,有空了改( |
fix: 自动安装选择 1.14.4 时 Quilt 卡片可能显示异常
Done in 6d88559. Now Fabric API is able to be selected with Quilt selected. I've also added a hint when you select both Quilt and Fabric API, but QSL is actually available. If QSL is not available, Fabric API will be selected automatically. @3gf8jv4dv @hejiehao Have a test and leave comments. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how it happens... |
button event binding issue? |
Are there plans to implement #1784 in this PR? |
I this #1784 need another pr. |
与 NeoForge 类似,本 PR 将基于先前的 Fabric 安装流程,加入针对 Quilt 的支持。
Close #48
效果预览 / Preview
To-Do List:
Known Issues:
Note: 由于 Quilt 同步 API 的问题,BMCLAPI 暂时无法用于下载 Quilt。
先前的 PR 操作不当关了()