-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
新功能:加入一系列简单的管理版本资源界面 #4770
base: main
Are you sure you want to change the base?
新功能:加入一系列简单的管理版本资源界面 #4770
Conversation
Although... but LTCatt has rejected some of these features. |
不会加入非常复杂的内容,只有简单的查看(不会有非常详细的信息,比如存档内容、在线资源指向……)、删除、另存为什么的…… |
Waiting for your good news. |
我自己应该不会考虑添加这些功能……不过可以加进 PR Collection 啥的( |
刚发现 7965ca8 干爆了我 PR Collection |
So beautiful!!! I like that. Lightweight and practical. Review comments will be provided later (if available). |
This comment was marked as resolved.
This comment was marked as resolved.
资源包显示图标 部分图标修改 部分文案修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on the resource pack
程序出现未知错误:Could not find a part of the path '*:\PCL\.minecraft\versions\*\PCL\Resourcepacks\'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive, Boolean checkHost)
at PCL.PageVersionResourcePack.LoadFileList()
at PCL.PageVersionResourcePack.Reload()
at PCL.PageVersionResourcePack.PageSetupLaunch_Loaded(Object sender, RoutedEventArgs e)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.BroadcastEventHelper.BroadcastEvent(DependencyObject root, RoutedEvent routedEvent)
at System.Windows.BroadcastEventHelper.BroadcastLoadedEvent(Object root)
at MS.Internal.LoadedOrUnloadedOperation.DoWork()
at System.Windows.Media.MediaContext.FireLoadedPendingCallbacks()
at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
错误类型:System.IO.DirectoryNotFoundException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some opinions.
After copying the screenshot, no screenshot is seen in the Win
+V
clipboard interface. However, the screenshot function of some software can be used to view the corresponding screenshot on the above interface after taking the screenshot. Is it possible to implement it here?
For each screenshot in the screenshot interface, can you add rounded corners around the preview? The current effect looks a bit abrupt compared to the UI elements.
Plain Craft Launcher 2/Pages/PageVersion/PageVersionScreenshot.xaml
Outdated
Show resolved
Hide resolved
….xaml Co-authored-by: 3gf8jv4dv <[email protected]>
When I try to add rounded corners around the picture, the UI becomes strange. And there seems some issues with windows clipboard, it does not work very well sometimes. |
现在应该没什么问题了。 |
So far, this seems to be problematic yet. Maybe consider asking LTCatt for help. |
优先度会非常非常低 =。= |
Plain Craft Launcher 2/Pages/PageVersion/PageVersionResourcePack.xaml.vb
Outdated
Show resolved
Hide resolved
Plain Craft Launcher 2/Pages/PageVersion/PageVersionResourcePack.xaml.vb
Outdated
Show resolved
Hide resolved
Plain Craft Launcher 2/Pages/PageVersion/PageVersionShader.xaml.vb
Outdated
Show resolved
Hide resolved
《我不希望我的日志拿起来就被别人看懂》 Co-authored-by: 3gf8jv4dv <[email protected]>
前言
PCL2 竟然这么久还没有简单的版本资源管理界面
进度
本 PR 有相关资源图标参考
预览
其它一些话
很显然这打扰到了 PCL2 的一些功能开发进度,所以这可能长期不能被合并
毕竟功能还没写好