Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

xAvgCharWidth is calculated differently by fontTools and FontVal #33

Closed
madig opened this issue Dec 28, 2017 · 2 comments
Closed

xAvgCharWidth is calculated differently by fontTools and FontVal #33

madig opened this issue Dec 28, 2017 · 2 comments

Comments

@madig
Copy link

madig commented Dec 28, 2017

See googlefonts/ufo2ft#195. Not sure what to make of it.
@HinTak
Copy link
Owner

HinTak commented Dec 31, 2017

https://github.com/HinTak/Font-Validator/blob/master/OTFontFileVal/val_OS2.cs - line 105, does one way of calculation when OS/2 table is "exactly 3", and does something else if not. It should be changed to "larger than or equal to 3".

@HinTak
Copy link
Owner

HinTak commented Dec 31, 2017

Thanks for the report. I'll make the change and close this now. Please pull and rebuild.

@HinTak HinTak closed this as completed in 683f2e6 Dec 31, 2017
This was referenced Jul 30, 2018
Closed
Closed
HinTak added a commit that referenced this issue Jul 19, 2022
@HinTak
correct OS/2 xAvgCharWidth calculation for v4/v5 tables.
bcfdeb1 
v4/v5 tables did not exist when this code was last updated.

closes #33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madig @HinTak