Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide login and register buttons if they are disabled #179

Closed
CrabeDeFrance opened this issue Nov 6, 2023 · 1 comment · Fixed by #180
Closed

Hide login and register buttons if they are disabled #179

CrabeDeFrance opened this issue Nov 6, 2023 · 1 comment · Fixed by #180
Assignees
@Hirevo
Labels
C-enhancement Category: Enhancement M-frontend Module: Frontend P-medium Priority: Medium

Comments

@CrabeDeFrance
Copy link
Contributor

Hello !

First of all, thanks for the amazing work done with Alexandrie.

I would like to propose you this minor change : I think it is better to hide "login" and "register" buttons if they are not available, instead of being able to click on them and go to a white page.

Please review the MR and integrate it if this is OK for you.

Best regards
@CrabeDeFrance CrabeDeFrance mentioned this issue Nov 6, 2023
Merged
@Hirevo Hirevo self-assigned this Nov 13, 2023
@Hirevo Hirevo added C-enhancement Category: Enhancement P-medium Priority: Medium M-frontend Module: Frontend labels Nov 13, 2023
@Hirevo
Copy link
Owner

Hirevo commented Nov 13, 2023

Hello !
This is indeed a good idea, I'm completely on board with this.
Thank you for the proposition and for coming up with an accompanying PR, I really appreciate it !

Hirevo added a commit that referenced this issue Nov 13, 2023
@Hirevo
Merge pull request #180 from CrabeDeFrance/feature-hide-login-registe…
5cc8e74 
…r-buttons

 Hide login and register buttons if they are disabled #179
@Hirevo Hirevo linked a pull request Nov 13, 2023 that will close this issue
Hide login and register buttons if they are disabled #179 #180
Merged
@Hirevo Hirevo closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hirevo Hirevo

Labels
C-enhancement Category: Enhancement M-frontend Module: Frontend P-medium Priority: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide login and register buttons if they are disabled #179 CrabeDeFrance/alexandrie
2 participants
@Hirevo @CrabeDeFrance