Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to tower-sessions #175

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Move to tower-sessions #175

merged 5 commits into from
Oct 2, 2023

Conversation

Hirevo
Copy link
Owner

@Hirevo Hirevo commented Sep 26, 2023

As @maxcountryman, the author of the axum-sessions crate, has kindly notified us in #174, axum-sessions has been hitting some problems due to its dependence on async-sessions, and a successor crate called tower-sessions has been released, which is free of this dependency and less limited in its API design.

This PR, therefore, refactors Alexandrie to use this new tower-sessions crate instead of axum-sessions.

Closes #174.

@Hirevo Hirevo added P-medium Priority: Medium M-frontend Module: Frontend C-refactor Category: Refactor labels Sep 26, 2023
@Hirevo Hirevo self-assigned this Sep 26, 2023
@Hirevo
Copy link
Owner Author

Hirevo commented Sep 26, 2023

The code currently doesn't compile due to me not being sure of what to do regarding expanding session durations.
See this comment for more details.

@Hirevo
Copy link
Owner Author

Hirevo commented Oct 2, 2023

There isn't anything left blocking this from being merged.
This is ready.

@maxcountryman Thank you very much for your reactivity on the few issues I encountered.

@Hirevo Hirevo merged commit 3e82ec7 into master Oct 2, 2023
6 checks passed
@Hirevo Hirevo deleted the refactor/tower-sessions branch October 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor M-frontend Module: Frontend P-medium Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider if migrating to tower-sessions is appropriate
1 participant