Add snr and move detections to exif #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def transform_box(box, model_size, grid_size, index): | ||
| CLASS_NAMES = ['face', 'person', 'license-plate', 'car', 'bus', 'truck', 'motorcycle', 'bicycle'] | ||
|
|
||
| def get_label(class_id): |
There was a problem hiding this comment.
Might be good to use type hints in new python code
def get_label(class_id: int) -> Optional[str]:
It makes the code easier to read and there are vscode plugins that do type checking on annotated code
No need to do this in this PR if it would slow things down
| return CLASS_NAMES[class_id] | ||
| return None | ||
|
|
||
| def transform_box(box, model_size, grid_size, index, scale_config, class_id): |
There was a problem hiding this comment.
Is this code identical to detect_hdc.py in odc-api? https://github.com/Hivemapper/odc-api/pull/228/files
If so would it be possible to copy this from odc-api instead of duplicating the changes here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.