Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect unused type #207

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Remove incorrect unused type #207

merged 3 commits into from
Aug 30, 2024

Conversation

robbiecarlton
Copy link
Contributor

complete_transactions does not return an EntryHashB64.

It's possible we need to provide a type here (for zome_call_typed to work), but given that we don't consume it, I'm hoping not.

If we do need to provide a type, the exact type is about to change

zo-el
zo-el previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, else good

crates/core_app_cli/src/actions/pay_invoices.rs Outdated Show resolved Hide resolved
@zo-el zo-el merged commit 0f4a66d into main Aug 30, 2024
2 checks passed
@zo-el zo-el deleted the remove-unused-return-type branch August 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zo-el zo-el zo-el approved these changes

@peeech peeech Awaiting requested review from peeech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbiecarlton @zo-el