Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More deprecations #10056

Merged
merged 1 commit into from
Dec 18, 2020
Merged

More deprecations #10056

merged 1 commit into from
Dec 18, 2020

Conversation

MikeMcQuaid
Copy link
Member

More deprecations, disabling and removal for Homebrew 2.7.0.

Marking as critical to get these in for testing over the weekend and (hopefully) release 2.7.0 on Monday or Tuesday.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 18, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 18, 2020

Review period ended.

More deprecations, disabling and removal for Homebrew 2.7.0.
@EricFromCanada
Copy link
Member

EricFromCanada commented Dec 18, 2020

Also: suggest uncommenting this option's replacement: and shortening its description in pr-pull.

@MikeMcQuaid MikeMcQuaid merged commit 603a059 into Homebrew:master Dec 18, 2020
@MikeMcQuaid MikeMcQuaid deleted the more-deprecations branch December 18, 2020 14:47
@MikeMcQuaid
Copy link
Member Author

@EricFromCanada sorry, just saw that after merge. Could you open a PR?

@EricFromCanada
Copy link
Member

See #10059.

@SeekingMeaning
Copy link
Contributor

language/haskell.rb can be deleted too

@MikeMcQuaid
Copy link
Member Author

@SeekingMeaning Might leave that one more release because it breaks formulae pretty badly.

@SeekingMeaning
Copy link
Contributor

Will require "compat/language/haskell" inside language/haskell cause an error?

@MikeMcQuaid
Copy link
Member Author

Will require "compat/language/haskell" inside language/haskell cause an error?

@SeekingMeaning yes 🤦🏻 #10084

ChrisOrlando added a commit to ChrisOrlando/homebrew-puppet that referenced this pull request Dec 28, 2020
homebrew released version 2.7.0 on December 21st

announcement blog: https://brew.sh/2020/12/21/homebrew-2.7.0/

In the change notes under the item "Additional API deprecations,
disables and removals." this PR is linked:

Homebrew/brew#10056

In this PR, `brew cask` was moved from deprecated to disabled. If users
try to install software this way, they get a message like this now:

```
$ brew cask install puppetlabs/puppet/pdk
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 3 taps (homebrew/cask-versions, homebrew/core and homebrew/cask).
==> Updated Formulae
Updated 7 formulae.
==> Updated Casks
Updated 2 casks.

Error: Calling brew cask install is disabled! Use brew install [--cask] instead.
```
ChrisOrlando added a commit to ChrisOrlando/homebrew-puppet that referenced this pull request Dec 28, 2020
homebrew released version 2.7.0 on December 21st

announcement blog: https://brew.sh/2020/12/21/homebrew-2.7.0/

In the change notes under the item "Additional API deprecations,
disables and removals." this PR is linked:

Homebrew/brew#10056

In this PR, `brew cask` was moved from deprecated to disabled. If users
try to install software this way, they get a message like this now:

```
$ brew cask install puppetlabs/puppet/pdk
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 3 taps (homebrew/cask-versions, homebrew/core and homebrew/cask).
==> Updated Formulae
Updated 7 formulae.
==> Updated Casks
Updated 2 casks.

Error: Calling brew cask install is disabled! Use brew install [--cask] instead.
```
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 21, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants