Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask: Add TODOs to deprecate integrated cask commands #8390

Merged
merged 3 commits into from
Aug 19, 2020
Merged

cask: Add TODOs to deprecate integrated cask commands #8390

merged 3 commits into from
Aug 19, 2020

Conversation

whoiswillma
Copy link
Member

@whoiswillma whoiswillma commented Aug 18, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Move deprecation from cask cmds and into cmd.rb.

When deprecating the run method of each command, tests had to be rewritten to avoid calling the run method since otherwise a deprecation exception was thrown. By deprecating at the Cask::Cmd level, all cask cmd tests continue to pass.

@MikeMcQuaid MikeMcQuaid merged commit b26e04a into Homebrew:master Aug 19, 2020
@MikeMcQuaid
Copy link
Member

Nice cleanup, thanks again @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants