Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce shallow clone usage #8883

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Reduce shallow clone usage #8883

merged 1 commit into from
Oct 9, 2020

Conversation

MikeMcQuaid
Copy link
Member

GitHub has requested we request our usage of shallow clones. As a result:

  • do default to shallow clones on CI
  • do not do --shallow-since when setting up new repositories in brew update
  • do not support shallow clones of homebrew-core at all

We may consider in future unshallowing all clones unconditionally.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@MikeMcQuaid
Reduce shallow clone usage
2bdf3de 
GitHub has requested we request our usage of shallow clones. As a
result:

- do default to shallow clones on CI
- do not do --shallow-since when setting up new repositories in
  `brew update`
- do not support shallow clones of homebrew-core at all

We may consider in future unshallowing all clones unconditionally.
@MikeMcQuaid MikeMcQuaid merged commit cfd4870 into Homebrew:master Oct 9, 2020
@MikeMcQuaid MikeMcQuaid deleted the no-shallow branch October 9, 2020 09:35
scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Oct 13, 2020
@scpeters
Don't need to unshallow taps anymore
9901edb 
Since Homebrew/brew#8883, tapped repositories in CI
are not shallow, so we don't need to unshallow them.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Oct 13, 2020
Merged
scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Oct 13, 2020
@scpeters
Don't need to unshallow taps anymore (#320)
3e29b6c 
Since Homebrew/brew#8883, tapped repositories in CI
are not shallow, so we don't need to unshallow them.

Signed-off-by: Steve Peters <[email protected]>
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @BrewTestBot