Introduce Sorbet #135
Merged
Introduce Sorbet #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Bo98
force-pushed
the
sorbet
branch
3 times, most recently
from
f6119a2
to
408a05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last few errors are pending fixes upstream.
I'm using
typed: strong(higher type level thanstrict) to banT.untyped, including implicit untyped from external method returns, except for:src/github_client.rb(new wrapper)src/server.rbwhich I've made the only two files to interface with third-party gems. Those two files don't have
T.untypedanywhere explicitly but do interface with calling methods from gems that return values that are untyped (Tapioca's RBIs do not contain any type information and third-parties rarely ship their own RBIs). Octokit in particular is pretty bad for typechecking. The new GitHub wrapper I've made here doesn't really solve that problem but at least quarantines it to one place.