Skip to content

Commit

Permalink
[email protected]: fix for Xcode 8.3 (#143)
Browse files Browse the repository at this point in the history
Fixes build failure with >= Apple LLVM version 8.1.0 (clang-802.0.42).

The error is
```
../deps/v8/include/v8.h:5800:54: error: 'CreateHandle' is a protected member of 'v8::HandleScope'
```

Fix suggested by Thomas Rosenstein in nodejs/node-gyp#1160.
  • Loading branch information
ilovezfs authored Jun 2, 2017
1 parent 704283b commit 1eec325
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions [email protected]/v8-xcode-8.3.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h
index 222404c..3f1d239 100644
--- a/deps/v8/include/v8.h
+++ b/deps/v8/include/v8.h
@@ -812,14 +812,14 @@ class V8_EXPORT HandleScope {
return reinterpret_cast<Isolate*>(isolate_);
}

+ static internal::Object** CreateHandle(internal::Isolate* isolate,
+ internal::Object* value);
+
protected:
V8_INLINE HandleScope() {}

void Initialize(Isolate* isolate);

- static internal::Object** CreateHandle(internal::Isolate* isolate,
- internal::Object* value);
-
private:
// Uses heap_object to obtain the current Isolate.
static internal::Object** CreateHandle(internal::HeapObject* heap_object,

0 comments on commit 1eec325

Please sign in to comment.