Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

XMLMind Editor 3.5.2 #683

Closed
wants to merge 2 commits into from
Closed

Conversation

zzamboni
Copy link

Cask for XMLMind Editor 3.5.2, which is an old version but the last one that allows commercial use without purchasing a license.

@vitorgalvao
Copy link
Member

Are you sure this only works with java6 and not others? Either way, that’s not the correct way to do it (java is a complex issue), and we have a depends_on :java in the works (not yet functional).

A caveat is currently the correct solution for this. Which one depends on if this only works with that version of java or not.

Also pinging @radeksimko on this, as I do with many java-related issues.

@zzamboni
Copy link
Author

Thanks for the feedback. The app does not work with the system Java in Yosemite (1.8.0_25), produces some class conversion errors. With java6 it works fine. I have not tested with java7.

Can you suggest what would be the appropriate caveats stanza in this case? Something like this maybe?

caveats “If XMLEditor does not open files correctly, try installing the java6 cask”

On Jan 16, 2015, at 7:34 PM, Vítor Galvão [email protected] wrote:

Are you sure this only works with java6 and not others? Either way, that’s not the correct way to do it (java is a complex issue), and we have a depends_on :java Homebrew/homebrew-cask#7993 in the works (not yet functional).

A caveat is currently the correct solution for this. Which one depends on if this only works with that version of java or not.

Also pinging @radeksimko https://github.com/radeksimko on this, as I do with many java-related issues.


Reply to this email directly or view it on GitHub #683 (comment).

@zzamboni
Copy link
Author

I have replaced the java6 dependency with a caveats stanza. In my testing this application does not work with Java 7 or 8, it needs Java 6.

@vitorgalvao vitorgalvao mentioned this pull request Jan 22, 2015
@vitorgalvao
Copy link
Member

Thank you for the contribution. It will be merged in a different pull request due to some simple recommended alterations. Your contribution is still included (and still credited to you), with the appropriate modifications, when applicable.

Changes:

@zzamboni
Copy link
Author

Thanks!

On Jan 22, 2015, at 8:24 AM, Vítor Galvão [email protected] wrote:

Thank you for the contribution. It will be merged in a different pull request Homebrew/homebrew-cask#696 due to some simple recommended alterations. Your contribution is still included (and still credited to you), with the appropriate modifications, when applicable.

Changes:

Facilitated future updates Homebrew/homebrew-cask#4910.
Squashed commits https://github.com/caskroom/homebrew-cask/blob/master/CONTRIBUTING.md#squashing.
Removed extraneous line in caveat.

Reply to this email directly or view it on GitHub #683 (comment).

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants