Sparkle's finish_installation.app gets linked sometimes

[Crazor]

For some apps, e.g. Bartender, the finish_installation.app gets linked into ~/Applications. For others, e.g. Adium, this does not happen.

There is a line in Adium's cask to prevent this, but I feel this should be blacklisted. Sparkle is a pretty common framework, so this will happen with many apps. Also, linking .app bundles from inside an application's bundle doesn't sound that useful, and linking .app bundles from inside an application bundle's frameworks sounds completely useless to me.

So maybe .app bundles shouldn't be traversed at all.

[phinze]

Good point. brew-cask does a pretty dumb traversal when specifically linked apps are not mentioned. I like the idea to prune the walk at .app bundles.

[shrx]

Also happens with BetterTouchTool:

==> Success! bettertouchtool installed to /opt/homebrew-cask/Caskroom/bettertouchtool/latest
==> Linking BetterTouchTool.app to /Applications/BetterTouchTool.app
==> Linking finish_installation.app to /Applications/finish_installation.app
==> Linking BTTHelper.app to /Applications/BTTHelper.app

Edit: I'm not sure BTTHelper.app should be linked here either, it wasn't here before.

[phinze]

This will get taken care of with explicit app linking which is the path we've decided to take, so I'm going to close this issue.