Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrintNode latest #14423

Closed
wants to merge 1 commit into from
Closed

Add PrintNode latest #14423

wants to merge 1 commit into from

Conversation

timlo
Copy link
Contributor

@timlo timlo commented Oct 14, 2015

Add PrintNode client software

@adidalal
Copy link
Contributor

I found a versioned URL

So, the cask should be

  version '4.8.0'
  sha256 '3c8203d7200de76deeb0274b7ff69b54fd21e91a7140210c1459fd46f78b04fa'

  url "app.printnode.com/bundles/printnodemain/downloads/printnode/#{version}/PrintNode-#{version}+dd7.dmg"

Probably also want to add for the sake of completeness

depends_on :macos => '>= :mountain_lion'

@timlo
Copy link
Contributor Author

timlo commented Oct 15, 2015

There's definitely a versioned URL, but I was inferring from everything in the contributing doc that if there's a vendor link for a "latest" stable release that it would be preferred?

@jawshooah
Copy link
Contributor

@timlo We actually prefer versioned URLs (see #1021), though the documentation is a bit outdated in that regard.

@timlo
Copy link
Contributor Author

timlo commented Oct 15, 2015

Great, thanks for all the feedback @adityadalal924 & @jawshooah updated the cask.

@jawshooah
Copy link
Contributor

Thank you for the contribution. It needed some fixes, so they were made in 03ce5af. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@jawshooah jawshooah closed this Oct 15, 2015
@timlo timlo deleted the printnode branch October 28, 2015 17:31
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants