Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofirma: Improve uninstall config #151676

Closed
wants to merge 2 commits into from

Conversation

cdalvaro
Copy link
Contributor

After making any changes to a cask, existing or new, verify:

  • The submission is for a stable version or documented exception.
  • brew audit --cask --online autofirma is error-free.
  • brew style --fix autofirma reports no offenses.
  • brew uninstall --cask autofirma worked successfully.

Related with issue #50361

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jul 25, 2023
@bevanjkay
Copy link
Member

@cdalvaro Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

@bevanjkay bevanjkay added the awaiting user reply Issue needs response from a user. label Jul 26, 2023
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jul 27, 2023
@cdalvaro
Copy link
Contributor Author

@cdalvaro Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

Thank you for your suggestion @bevanjkay! I have already added the zap stanza.

@cdalvaro cdalvaro changed the title feat: Remove outdated uninstall postflight for autofirma autofirma: Improve uninstall config Jul 27, 2023
@cdalvaro
Copy link
Contributor Author

How can I relaunch the CI pipeline? I think it failed because of a temporary issue.

@krehel krehel added the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Jul 29, 2023
@BrewTestBot BrewTestBot removed the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Jul 29, 2023
@krehel
Copy link
Member

krehel commented Jul 29, 2023

Re-running CI for you @cdalvaro

@cdalvaro
Copy link
Contributor Author

cdalvaro commented Jul 29, 2023

I think the CI / test autofirma (macOS-13, intel) is reaching a timeout because it is waiting for a sudo password.

How can I solve it?

@cdalvaro
Copy link
Contributor Author

cdalvaro commented Jul 29, 2023

This PR is related with #88469

@bevanjkay
Copy link
Member

bevanjkay commented Jul 31, 2023

@cdalvaro The installer is prompting the user with a GUI before continuing which is stalling out the installer. homebrew-cask only supports unattended installation/uninstallation, so we will need to address this before proceeding.

@cdalvaro
Copy link
Contributor Author

@cdalvaro The installer is prompting the user with a GUI before continuing which is stalling out the installer. homebrew-cask only supports unattended installation/uninstallation, so we will need to address this before proceeding.

Right now this cask cannot be uninstalled because of an error related with the certificates it tries to uninstall:

brew uninstall --cask --zap autofirma
==> Implied `brew uninstall --cask autofirma`
==> Uninstalling packages; your password may be necessary:
==> Removing files:
/Applications/AutoFirma.app
Password:
Unable to delete certificate matching "AutoFirma ROOT"Error: Failure while executing; `/usr/bin/sudo -E -- /usr/bin/security delete-certificate -c AutoFirma\ ROOT` exited with 1. Here's the output:
Unable to delete certificate matching "AutoFirma ROOT"

Could we merge this PR and solve the issue with the password prompt in another PR?

@bevanjkay
Copy link
Member

@cdalvaro If the installer cannot pass CI we would be looking to instead remove the cask.

@bevanjkay
Copy link
Member

/rebase

Find for 'AutoFirma ROOT' certificate before trying to remove it.
@cdalvaro
Copy link
Contributor Author

cdalvaro commented Aug 9, 2023

Hi @bevanjkay, thank you for watching this PR.

I don't think the CI will pass.

The installer (when is manually executed) requires the user's password, and there is no way to change the install directory for another one with user permissions.

This is an official application from the Spanish Government, so I think the right place to have the cask is in the official Homebrew's cask repo. However, I understand your policy.

If you consider this cask should be removed. Please, close this PR. But I prefer not to be the one who removes this cask from your repository. Since many people may rely on it.

Thank you again for your time.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Aug 18, 2023
@p-linnane
Copy link
Member

Closing as this cannot be merged. Let's continue with current state as long as possible.

@p-linnane p-linnane closed this Aug 22, 2023
@bevanjkay
Copy link
Member

@p-linnane I don't believe that the current cask is functional headlessly as-is. I can't even stop the GUI installer without first closing my browser...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants