-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Caskroom location, see #475 #2066
Conversation
@halo Can you write a test for this change? |
Sorry, I simply forgot. I added the test now, it's basically the same as for the
|
It would imo be better to use a new wiki page for option descriptions, or a section on an existing one. Additionally, why would that option be given more visibility than the others, by having it as example? Is it really going to be the one most people look for? Do we even have data on this? Examples need not be random, they can have an agenda, make sure it's not wasted on something few people will engage with, maybe? |
Ah, good points good points. I will come up with something. |
What do you think? You can see the results here. I thought about adding a wiki page, but I think it's clearer to have everything at your fingertips in the very same revision control. |
This is great @halo - thanks for you work on this! Merging now. |
Configurable Caskroom location, see #475
No description provided.