Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cask for Sublime Text 3 beta #212

Closed
wants to merge 2 commits into from

Conversation

mwarkentin
Copy link
Contributor

No description provided.

@vitorgalvao
Copy link
Member

I'm a bit divided on this one. On one hand, it is useful, yes, but I don't really want to start the precedent (I think, maybe it wouldn't be the first) of having different casks for different versions of one app.

It seems it could get confusing, specially since in this case if you're a registered user you have access to it, which means you also presumably know of it. It’s different from a trial, since you can download one of those and still use it, but this one could be unusable if you don’t know that it’s available only to registered users.

I’m also worried for the future of it. Changing casks’ names (it would eventually be deleted and substitute the current one) always makes me think that we could be breaking someone’s script (I may be biased here, as I use a script to manage my casks, not sure if anyone else does).

I voiced my concerns, so I’ll leave this one to @phinze — being his project, he should have final say on these matters.

@mwarkentin
Copy link
Contributor Author

Definitely understandable - seems like #142 would be the ideal way to deal with this.

@jacobian
Copy link
Contributor

It seems like textmate1 and textmate2 made it in, so can this?

@vitorgalvao
Copy link
Member

They made it previously, but textmate 1 will be removed soon (for some of the same reasons this wasn’t merged yet).

We have to strike some balance between available apps and possible user confusion; even a recent pull request for a dev version was put on hold, and we’re talking about standardizing cask names.

As @mwarkentin mentioned (and I agree), #142 would provide the place for this. I don’t believe different casks for different versions of apps to be an acceptable solution (for reasons mentioned previously, and on other issues), and I think we can do better.

@sheerun
Copy link
Contributor

sheerun commented Sep 21, 2013

ST3 is since Build 3047 a public beta. No registration needed. I guess it's ok to merge.

@fanquake
Copy link
Contributor

@mwarkentin Can you update this pull request to the latest beta version (3047)?

@sheerun
Copy link
Contributor

sheerun commented Sep 30, 2013

This PR was with latest: #1063

@mwarkentin
Copy link
Contributor Author

@fanquake Done.

@phinze
Copy link
Contributor

phinze commented Oct 21, 2013

Hey thanks to our new beta policy, I can finally merge this! Thanks for sticking around. 🌝

@mwarkentin
Copy link
Contributor Author

@phinze Is there a discussion or issue for the beta policy? Just curious. :)

@mwarkentin mwarkentin deleted the sublime-text-3 branch October 21, 2013 13:13
@phinze
Copy link
Contributor

phinze commented Oct 21, 2013

@mwarkentin sorry should have linked from original mention; check out #1171 for the meeting minutes 📝

@hanxue
Copy link
Contributor

hanxue commented Oct 21, 2013

I see that #1240 is linked to this issue - will the pull request be merged?

By the way, I fail to find any references on beta policy. Can someone be kind enough to point me to the page, as well as other docs not within the git repo, i.e. meeting minutes, etc?

@mwarkentin
Copy link
Contributor Author

@hanxue You can see the notes here: #1171

@mwarkentin
Copy link
Contributor Author

Was this removed for some reason?

@nanoxd
Copy link
Contributor

nanoxd commented Dec 3, 2013

@mwarkentin The cask can be found in caskroom/homebrew-versions

@mwarkentin
Copy link
Contributor Author

Ah, thank you!

kevinSuttle pushed a commit to kevinSuttle/homebrew-cask that referenced this pull request Dec 8, 2013
faun pushed a commit to faun/homebrew-cask that referenced this pull request Jun 15, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants