Fix triumph.rb: Remove DDP Player.app artifact #21413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triumph.app contains in its bundle three helper tools. Those tools are meant to be accessed from the menu bar while using Triumph. One of those tools, DDP Player.app, is defined as an artifact though. With upcoming PR #13966, `cask install` would rip out DDP Player.app from the bundle. As a consequence, invoking the *DDP Player* menu item would cause Triumph to crash. This commit fixes the issue by removing the artifact altogether. All the tools (including DDP Player) should be launched from the *Tools* menu as intended, e. g.: > Triumph » Tools » DDP Player
chizmw
pushed a commit
to chizmw/homebrew-cask
that referenced
this pull request
Jun 15, 2016
Triumph.app contains in its bundle three helper tools. Those tools are meant to be accessed from the menu bar while using Triumph. One of those tools, DDP Player.app, is defined as an artifact though. With upcoming PR Homebrew#13966, `cask install` would rip out DDP Player.app from the bundle. As a consequence, invoking the *DDP Player* menu item would cause Triumph to crash. This commit fixes the issue by removing the artifact altogether. All the tools (including DDP Player) should be launched from the *Tools* menu as intended, e. g.: > Triumph » Tools » DDP Player
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to a cask
Editing an existing cask
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}left no offenses.Rationale
Triumph.app contains in its bundle three helper tools. Those tools are meant to be accessed from the menu bar while using Triumph.
One of those tools, DDP Player.app, is defined as an artifact though. With upcoming PR #13966,
cask installwould rip out DDP Player.app from the bundle. As a consequence, invoking the DDP Player menu item would cause Triumph to crash.This commit fixes the issue by removing the artifact altogether. All the tools (including DDP Player) should be launched from the Tools menu as intended, e. g.: