Fix zap regression introduced in 6500fa1; ref #21583
#21607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue with 6500fa1, in which the (internal) installer API was refactored in preparation for the big change. That refactoring missed one case, causing `zap` to break; see #21583. There are **no tests** included with this fix due to pre-existing coverage issues. Test will follow in a separate commit.
Please do! Commented-out blocks of code do no one any good; let's figure out what's wrong and fix it before something else breaks. |
|
LGTM, don't want zap broken for too long :) |
Closed
|
Thanks @jawshooah and @adidalal. |
chizmw
pushed a commit
to chizmw/homebrew-cask
that referenced
this pull request
Jun 15, 2016
…rew#21607) This PR fixes an issue with 6500fa1, in which the (internal) installer API was refactored in preparation for the big change. That refactoring missed one case, causing `zap` to break; see Homebrew#21583. There are **no tests** included with this fix due to pre-existing coverage issues. Test will follow in a separate commit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with 6500fa1, in which the (internal) installer API was refactored in preparation for the big change. That refactoring missed one case, causing
zapto break; see #21583.@caskroom/maintainers This is a one-line fix but please have a look nonetheless. Thanks!
Caveats:
zapcommand seems to have test coverage issues. We do have acli/zap_testcase but its main path is commented out. When I uncomment that test, it keeps failing and I can’t figure out why. Shall I open an issue for this on its own?13966 has exposed a few more (unrelated) issues with
uninstallandzapin edge cases when the user has insufficient permissions. This is easily fixable (using methods from 9664b9f); I am preparing a PR right now.