Add Pale Moon version 26.5.0 #27191
Add Pale Moon version 26.5.0 #27191
Conversation
Adds the app Pale Moon (Newmoon.app) for MacOS. Would like to add version 27 seperately as it is a major rebase that breaks some features.
| @@ -0,0 +1,10 @@ | |||
| cask 'palemoon' do | |||
| version '26.5.0' | |||
There was a problem hiding this comment.
Please change the version to 26.5.0-131.
There was a problem hiding this comment.
Do you mean 26.5.0-131? otherwise #{version} will not work
| version '26.5.0' | ||
| sha256 '617581f55863b2ab0f55538791d2c82a06378febffebce14b8d1c1d625f465cb' | ||
|
|
||
| url 'https://mac.palemoon.org/dist/palemoon-26.5.0-131-gstreamer.en-US.mac64.dmg' |
There was a problem hiding this comment.
Please change this to
url "https://mac.palemoon.org/dist/palemoon-#{version}-gstreamer.en-US.mac64.dmg"
Adds the full version number to Pale Moon cask and fixes URL stanza to download #{version}
ibrokemypie
force-pushed
the
add-palemoon
branch
from
94a2581
to
334aca2
Compare
| @@ -0,0 +1,10 @@ | |||
| cask 'palemoon' do | |||
There was a problem hiding this comment.
Token reference was not followed.
There was a problem hiding this comment.
token reference says to use newmoon as the file is called NewMoon.app, however the application is official named Pale Moon, so went with that
There was a problem hiding this comment.
And the token reference also explains why that doesn’t matter and why it must be followed.
There are specific cases where it can be circumvented, with clear rules as how to do so and when.
There was a problem hiding this comment.
have updated to follow token reference
Changed the PaleMoon cask to be newmoon as according to token reference
After making all changes to the cask:
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}worked successfully.brew cask uninstall {{cask_file}}worked successfully.Adds the app Pale Moon (Newmoon.app) for MacOS. Would like to add version 27 seperately as it is a major rebase that breaks some features.