DSL: add install_script stanza
#4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rolandwalker
changed the title
installer stanza (WIP)install_command stanza (WIP)
rolandwalker
changed the title
install_command stanza (WIP)install_script stanza (WIP)
so that it can be called from multiple stanzas
as parameters. Accept overridden keys when submitted by the caller, but warn that they are ignored.
rolandwalker
changed the title
install_script stanza (WIP)install_script stanza
name matches `uninstall :script` References: Homebrew#4688
rolandwalker
added a commit
that referenced
this pull request
Jul 2, 2014
DSL: add `install_script` stanza
Merged
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to run an installation script, providing cleaner syntax than
the current method, which is to use
caskroom_onlyfollowed byafter_install.(example adobe-air.rb).
This PR is in almost working form. It is marked WIP becausetests are failingFIXED?installerdoesn't seem like the right name for the stanzainstall_scriptfor consistency withuninstall :scriptinstall :scriptwould be even more consistent, but the overlap with an existing stanza name would make a transition difficultwe are changinginstalltopkg, so that would reduce one source of confusion. But the Apple-provided CLI tool for installingpkgfiles is also calledinstaller.what is a better name?install_script<----- consistent withuninstall :scriptinstall_command?installer_script?installer_command?custom_installer?cli_installer?References: #4688