Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* official FileBot homebrew/cask package by rednoah #5062

Merged
merged 1 commit into from
Jun 25, 2014
Merged

* official FileBot homebrew/cask package by rednoah #5062

merged 1 commit into from
Jun 25, 2014

Conversation

rednoah
Copy link
Contributor

@rednoah rednoah commented Jun 25, 2014

Hi,

I'm the creator of filebot and I'd like to take over maintenance of the cask package myself. Here's an update for the latest release.

Cheers,
Reinhard

@rolandwalker
Copy link
Contributor

Hi @rednoah! Thanks for the update.

We can ignore the Travis error here; it's just a glitch.

rolandwalker added a commit that referenced this pull request Jun 25, 2014
* official FileBot homebrew/cask package by rednoah
@rolandwalker rolandwalker merged commit 6a75dcf into Homebrew:master Jun 25, 2014
@vitorgalvao
Copy link
Member

It’s great to see a project’s creator taking such initiative. Thank you.

The cask should still be consistent with the others, naturally, so the double quotes should be changed to single quotes. Double quotes are to be used only when they are needed (variable substitution).

We also have a recommended stanza order that we’re transitioning to, and are trying to make casks easier to update, when applicable. I’ll submit a pull request with these changes. You’ll then need to only update the version and sha256 fields.

Regarding the caveat, we intend to expose dependencies in a better way, in the future.

@rednoah
Copy link
Contributor Author

rednoah commented Jun 25, 2014

I'll keep that in mind for next time. Thanks for fixing it. ;)

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants