Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacDown 0.1 #5076

Closed
wants to merge 1 commit into from
Closed

MacDown 0.1 #5076

wants to merge 1 commit into from

Conversation

hanxue
Copy link
Contributor

@hanxue hanxue commented Jun 26, 2014

No description provided.

@vitorgalvao
Copy link
Member

Could you please amend the commit message to something clearer? The way it stands, it seems like the cask is being added. Personally, when making this changes phrase the commit message as “made cask_name easier to update”.

@hanxue
Copy link
Contributor Author

hanxue commented Jun 26, 2014

It is a new cask being added. Sorry if I am not being clear. I am following Homebrew's style of "<formula_name> <version_number>"

I will amend the commit anyway - just got the appcast URL from the software author

New cask MacDown, version 0.1 - with appcast xml
@nanoxd nanoxd closed this in d23f153 Jun 26, 2014
@nanoxd
Copy link
Contributor

nanoxd commented Jun 26, 2014

Merged

@hanxue
Copy link
Contributor Author

hanxue commented Jun 26, 2014

@nanoxd thank you for fixing the download url

@hanxue hanxue deleted the macdown branch June 26, 2014 17:42
@vitorgalvao
Copy link
Member

Well, not exactly, the cask was added in #5071, you just added the appcast.

You also did the reverse of what I was thinking. I appreciate you taking the care to shift stanzas around for consistency, but we’re actually transitioning to a new order of stanzas, so that work was actually undone. Not a big deal, but since you’re a regular contributor, wanted to let you know that that is now the preferred way.

@nanoxd
Copy link
Contributor

nanoxd commented Jun 26, 2014

@vitorgalvao I fixed the commit to retain the new unofficial format.

@vitorgalvao
Copy link
Member

@nanoxd Thank you.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants