Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pCloud drive cask version 3.7.9 #57634

Closed
wants to merge 1 commit into from
Closed

Add pCloud drive cask version 3.7.9 #57634

wants to merge 1 commit into from

Conversation

tomgross
Copy link

@tomgross tomgross commented Jan 18, 2019

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@tomgross
Copy link
Author

There was an refused cask in #51552 because the download URL was volatile. This no longer seems to be the case.

@tomgross
Copy link
Author

Everything except uninstall on travis works now. After installation an instance of pcloud (com.pcloud.pcloud.macos) is running. It needs to be killed before uninstalling. Any help appreciated.

@vitorgalvao
Copy link
Member

Thank you, but if this needs parsing a JSON response, we don’t want it. url do is meant to be used for nightly releases and the like, so they can be kept up to date. If this is needed for a stable release, than it’s unlikely the devs are happy we’re linking to it directly, and we’d rather not include it.

@tomgross
Copy link
Author

@vitorgalvao Thanks for the review. It's unfortunate you don't support this in the stable release. In this case it is a feature of pCloud itself. Release packages of pCloud are hosted on the same infrastructure as the cloud storage (which makes sense if you are a cloud storage company ;-)

Creating and accessing URL tokens are part of their API to generate secure and scalable one time URLs for downloading content. (see https://docs.pcloud.com/methods/public_links/getpublinkdownload.html)

Obviously there are other people interessted in this (see #51552) but if it is against your policy fair enough.

@vitorgalvao
Copy link
Member

I understand their reason for doing it, but it’s incompatible with our system. URLs with changing tokens exist to make it hard to perform automomated downloads, and are nor worth the hassle for us.

@tomgross
Copy link
Author

OK I understand. If this is useful for someone else I created a gist for installing pCloud drive on a Mac via homebrew cask: https://gist.github.com/tomgross/bae4f30023272d8c8c0d920b62720c6b

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 19, 2019

Instead of a gist, consider a tap.

@lock lock bot added the outdated label Feb 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants