Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL: change container_type to extensible container #6068

Merged
merged 1 commit into from
Sep 8, 2014

Conversation

rolandwalker
Copy link
Contributor

Late addition to DSL 1.0 (oversight in the roadmap)

References: #4688

New syntax:

container :type => :naked

This is obviously more extensible than container_type, but I simply forgot to make
this amendment in #4688.

An example of what else might possibly be added in this stanza is renaming:

container :rename => 'bankid-latest.pkg'

So that we wouldn't need this hack. No sure yet; just an example.

@caskroom/maintainers, as this only affects 5 Casks in the main repo, I am comfortable
pushing in this change at the last minute and including it in DSL 1.0. The chance that
a user will actually be inconvenienced is very small.

Late addition to DSL 1.0 (oversight in the roadmap)

References: Homebrew#4688
@rolandwalker
Copy link
Contributor Author

I'm going to be a little bit bad and push this through right away so I can cut a release.

rolandwalker added a commit that referenced this pull request Sep 8, 2014
DSL: change container_type to extensible container
@rolandwalker rolandwalker merged commit b8523e2 into Homebrew:master Sep 8, 2014
@rolandwalker rolandwalker deleted the container_dsl branch September 8, 2014 14:04
rolandwalker added a commit to rolandwalker/homebrew-cask that referenced this pull request Sep 10, 2014
Copypasta error in Homebrew#6068 means that container :type
never worked, because it looked for nonexistent container.formula
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant