DSL: add stanza stage_only (new spelling of caskroom_only)
#7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added
the
core
`caskroom_only` was never documented. Its original purpose was obsoleted in Homebrew#4865, and its use has been recently been reduced to two Casks. This PR * continues the rationalization of naming by changing `caskroom_only` to `stage_only`. "stage" is the verb for "make a copy under the caskroom directory" * documents `stage_only` * adds tests for `stage_only` * validates the argument to `stage_only` * gives sensible output in `brew cask info` for `stage_only` Casks * enforces that `stage_only` cannot coexist with any activatable artifacts `caskroom_only` is still supported for backward compatibility, but should be removed before 0.50.0.
rolandwalker
force-pushed
the
add_stage_only
branch
from
e608691
to
88b2e92
Compare
|
Looks good. |
tapeinosyne
pushed a commit
that referenced
this pull request
Nov 18, 2014
DSL: add stanza `stage_only` (new spelling of `caskroom_only`)
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caskroom_onlywas never documented. Its original purpose was obsoleted in #4865, and its use has been recently been reduced to two Casks.This PR
caskroom_onlytostage_only. "stage" is the verb for "make a copy under the caskroom directory"stage_onlystage_onlystage_onlybrew cask infoforstage_onlyCasksstage_onlycannot coexist with any activatable artifactscaskroom_onlyis still supported for backward compatibility, but should be removed before 0.50.0.