Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name stanza for proper name #7805

Merged
merged 1 commit into from
Dec 6, 2014

Conversation

rolandwalker
Copy link
Contributor

Following up on #7673, add a name stanza

  • This will obsolete tags :name (before it ever really gets started)
  • Documentation will be in a separate PR so that authors don't start using the feature before code release
  • Future plan would be to make this mandatory
  • Proposed placement in create template is high, which may warrant discussion

There is a bit of hackery needed to expose name in the DSL, because Ruby has already defined a name method. On the backend, this is everywhere referred to as full_name.

Exposing simply name has the virtue of clearly directing all naming activities away from the token, which cannot bear the weight.

@rolandwalker rolandwalker added the core Issue with Homebrew itself rather than with a specific cask. label Dec 4, 2014
@vitorgalvao
Copy link
Member

I like the placement, but I’d move it one line down. It’s grouped with url, homepage, and license, i.e. the ones that shouldn’t need much fiddling after the initial setup (considering url has some form of version interpolated, or is always pointing to the latest version). However, for the cases url does need to change, it makes sense to have it higher up; I’ll also use as reasoning that (at least to me) having name and homepage together makes more sense than name and url.

On a tangent note, perhaps we should consider moving appcast higher up, together with version and sha256, since that will also change with every version (because it too has a sha256).

Documentation is in a separate PR so that authors don't start
using this feature before release.
@rolandwalker
Copy link
Contributor Author

Sure thing. Changed here and in the doc PR.

I'm not ready to move appcast yet. Hopefully the appcast checksums are just a transitional thing we just use to get started (for 99% of cases). What's not yet defined is how appcast will interact with version. That will affect how volatile the appcast stanza may be.

Logically, the appcast doesn't need to be volatile, if the software does the work instead of the Cask author, and I'm trying to get to that.

Also, it's been poorly explained, but I'm purposefully letting the appcast data "cook" for a little while in the real world to gather various cases to develop against.

rolandwalker added a commit that referenced this pull request Dec 6, 2014
@rolandwalker rolandwalker merged commit f5bcbd0 into Homebrew:master Dec 6, 2014
@rolandwalker rolandwalker deleted the add_name_stanza branch December 6, 2014 10:28
@miccal miccal removed the core Issue with Homebrew itself rather than with a specific cask. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants