Separate verification from download #9216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2015 15:32
and merge them into a single definition.
With the expectation that: - we will add gpg checks; - we may add a `verify` verb; - we may introduce new means of verification, e.g. OS X's `codesign`
as a distinct step serving the general purpose of verification, e.g. of integrity with sha, authenticity with gpg…
|
Nice! LGTM |
tapeinosyne
added
the
core
tapeinosyne
pushed a commit
that referenced
this pull request
Jan 25, 2015
Separate verification from download
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor, aiding future updates in general and #8749 in particular. We gain a better arrangement for expansion by isolating download strategies and pathstitching from a general provider of verification methods.
Refer to #5971, #7062.
Kindly summoning @phinze for review.