Skip to content

Commit

Permalink
yarn: remove options. (#36222)
Browse files Browse the repository at this point in the history
  • Loading branch information
@MikeMcQuaid
MikeMcQuaid authored Jan 21, 2019
1 parent 60b80cf commit 4cb921e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Formula/yarn.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class Yarn < Formula

bottle :unneeded

depends_on "node" => :recommended
depends_on "node"

conflicts_with "hadoop", :because => "both install `yarn` binaries"

Expand Down

4 comments on commit 4cb921e

@aforty
Copy link

@aforty aforty commented on 4cb921e Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

@zengxs
Copy link
Contributor

@zengxs zengxs commented on 4cb921e Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is very useful, and it will not make it compile from source code.

I think we can keep this option.

@aforty
Copy link

@aforty aforty commented on 4cb921e Feb 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of this option means that I cannot install yarn from Homebrew without also installing node. I get node from nvm.

Can this option be added back in?

@iMichka
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. No.

See #36222 (comment)

yarn depends on node: it does not function without it. #31510 provides context. Instead of trying to install without Homebrew' node instead adjust your PATH so nvm's nodes are before Homebrew's node

Please sign in to comment.