Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: add Vulkan/molten-vk support #117295

Closed
wants to merge 1 commit into from

Conversation

EndangeredNayla
Copy link

  • Have you followed the guidelines for contributing?

  • Have you ensured that your commits follow the commit style guide?

  • Have you checked that there aren't other open pull requests for the same formula update/change?
    qt 6.4.1 #115926 exists but is also for something else, this PR just deals with Vulkan

  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?


@BrewTestBot BrewTestBot added CI-linux-self-hosted Build on Linux self-hosted runner ffmpeg FFMPEG use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue labels Dec 4, 2022
@EndangeredNayla
Copy link
Author

Im willing to disuss this further over IRC or whatever the homebrew community uses

@cho-m
Copy link
Member

cho-m commented Dec 5, 2022

Previous attempts:

Comments from last attempt still hold: #111474 (comment)

please test that your changes produce the intended result, and update the formula's test to include a minimal check for the usability of the new features.

@fxcoudert
Copy link
Member

These have been incorporated, as well as a test, in the latest update.

@fxcoudert fxcoudert closed this Dec 12, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner ffmpeg FFMPEG use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants