Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite-sparse 6.0.3 #118915

Closed
wants to merge 7 commits into from
Closed

suite-sparse 6.0.3 #118915

wants to merge 7 commits into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Dec 25, 2022
@chenrui333
Copy link
Member

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Dec 25, 2022
@chenrui333
Copy link
Member

also relates to JuliaLang/julia#47884

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 27, 2022
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Dec 28, 2022
@cho-m
Copy link
Member

cho-m commented Jan 3, 2023

The Julia warning seems odd. SuiteSparse v6 comes with CHOLMOD v4 so that should be the version picked up during compile time.

However, the warning is just spamming output logs but it isn't the reason test failed:

ERROR: InitError: could not load library "@rpath/libamd.2.dylib"
  dlopen(@rpath/libamd.2.dylib, 0x0001): tried: '/opt/homebrew/Cellar/julia/1.8.3_1/lib/julia/libamd.2.dylib' (no such file), '/opt/homebrew/opt/curl/lib/libamd.2.dylib' (no such file), '/opt/homebrew/opt/mbedtls@2/lib/libamd.2.dylib' (no such file), '/opt/homebrew/opt/openblas/lib/libamd.2.dylib' (no such file), '/opt/homebrew/opt/gcc/lib/gcc/current/libamd.2.dylib' (no such file), '/opt/homebrew/lib/libamd.2.dylib' (no such file), '/usr/lib/libamd.2.dylib' (no such file), '/opt/homebrew/Cellar/julia/1.8.3_1/bin/../lib/libamd.2.dylib' (no such file)

@cho-m
Copy link
Member

cho-m commented Jan 3, 2023

Looks like the library versions are fixed probably to avoid API breakage: https://github.com/JuliaLang/julia/blob/v1.8.4/stdlib/SuiteSparse_jll/src/SuiteSparse_jll.jl#L57

No changes on HEAD or beta releases, so not sure on timeframe this will be fixed. Fastest way would be to bundle a copy of SuiteSparse 5 with Julia.

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long build Set a long timeout for formula testing labels Jan 4, 2023
@cho-m cho-m added long build Set a long timeout for formula testing maintainer feedback Additional maintainers' opinions may be needed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jan 5, 2023
Comment on lines -72 to +76
USE_SYSTEM_LIBSUITESPARSE=1
USE_SYSTEM_LIBSUITESPARSE=0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @carlocab @fxcoudert if any concern on using julia's bundled copy of suite-sparse.

It doesn't look like HEAD supports SuiteSparse 6 yet, so I doubt we will get support in near future.

Copy link
Member

@cho-m cho-m Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove do not merge in about 8 hours (1 day since above post). Afterward, we can use any of the open julia PRs if an alternative approach is preferred.

@cho-m cho-m removed in progress Stale bot should stay away upstream issue An upstream issue report is needed labels Jan 6, 2023
@cho-m cho-m mentioned this pull request Jan 6, 2023
6 tasks
@cho-m cho-m added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Jan 6, 2023
@cho-m cho-m mentioned this pull request Jan 6, 2023
@cho-m cho-m removed do not merge maintainer feedback Additional maintainers' opinions may be needed labels Jan 7, 2023
@BrewTestBot
Copy link
Member Author

:shipit: @cho-m has triggered a merge.

@p-linnane p-linnane deleted the bump-suite-sparse-6.0.3 branch February 24, 2024 21:15
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants