terraform: match upstream ldflags for version

[cho-m]

Closes #127453

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

See https://github.com/hashicorp/terraform/actions/runs/4568417937/jobs/8063451319#step:5:11

  go build -ldflags "-w -s -X 'github.com/hashicorp/terraform/version.Version=1.4.4' -X 'github.com/hashicorp/terraform/version.Prerelease='" -o dist/ .

and https://github.com/hashicorp/terraform/blob/v1.4.4/.github/scripts/get_product_version.sh#L28-L29

LDFLAGS="${LDFLAGS} -X 'github.com/hashicorp/terraform/version.Version=${BASE_VERSION}'"
LDFLAGS="${LDFLAGS} -X 'github.com/hashicorp/terraform/version.Prerelease=${PRERELEASE}'"

[nandahkrishna]

Let's perhaps add a test to ensure that the right version number is returned – will also help us check if this worked as intended.

[SMillerDev]

I don't think we should override it if upstream sets this already

[cho-m]

I guess we can wait for upstream build system changes to finalize if they introduce hashicorp/terraform#32973 to align version number / pre-release info.

May need to check on how next upstream build flow looks to see if that goes in or we need to manually set github.com/hashicorp/terraform/version.Prerelease to remove -dev label on version number.