Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2023.07.17.00 #136782

Merged
merged 19 commits into from
Jul 23, 2023

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 17, 2023
@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Jul 17, 2023

  CMake Error at CMakeLists.txt:106 (find_package):
    Could not find a package configuration file provided by "mvfst" with any of
    the following names:
  
      mvfstConfig.cmake
      mvfst-config.cmake

fbthrift now depends on mvfst. The latter has no tagged releases, and is not available in core currently. I filed facebook/mvfst#301 to ask mvfst maintainers if they are interested in providing weekly releases.

@carlocab
Copy link
Member

mvfst is also an optional dependency of proxygen.

@carlocab carlocab force-pushed the fb-2023.07.17.00 branch 2 times, most recently from 2ebac8c to d5122b4 Compare July 17, 2023 16:18
@carlocab
Copy link
Member

mvfst also needs some fixes for new fmt. 🙃

@carlocab
Copy link
Member

carlocab commented Jul 18, 2023

I'm thinking quic::LocalErrorCode needs a formatter specialisation?

Or maybe a similar fix to here: facebook/folly#2022

@carlocab
Copy link
Member

fb303 fails with:

  CMake Error at /opt/homebrew/lib/cmake/fbthrift/FBThriftConfig.cmake:56 (find_package):
    Could not find a package configuration file provided by "mvfst" with any of
    the following names:
  
      mvfstConfig.cmake
      mvfst-config.cmake
  
    Add the installation prefix of "mvfst" to CMAKE_PREFIX_PATH or set
    "mvfst_DIR" to a directory containing one of the above files.  If "mvfst"
    provides a separate development package or SDK, be sure it has been
    installed.
  Call Stack (most recent call first):
    CMakeLists.txt:58 (find_package)

@carlocab carlocab force-pushed the fb-2023.07.17.00 branch 3 times, most recently from ddddbfc to bbccb8a Compare July 21, 2023 07:34
@carlocab carlocab added new formula PR adds a new formula to Homebrew/homebrew-core and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jul 21, 2023
@carlocab carlocab changed the title edencommon fb303 fbthrift fizz folly proxygen wangle watchman 2023.07.17.00 edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2023.07.17.00 Jul 21, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2023
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2023
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 21, 2023
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 23, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 23, 2023
Merged via the queue into Homebrew:master with commit 3107573 Jul 23, 2023
@ZhongRuoyu ZhongRuoyu deleted the fb-2023.07.17.00 branch July 27, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants