whatweb 0.5.5 (new formula) #140724

oregonpillow · 2023-08-28T21:10:45Z

whatweb is a ubiquitous tool used for enumeration of web servers and other IOT devices. Commonly used within penetration testing and security audits, I felt that this tool should be provided as a Brew package. A known issue is that macOS versions older than Monterey require an updated Ruby version. Therefore is is expected that running brew bot tests for whatweb will trigger an error since it wants 'depends_on' to be replaced by 'uses_from_macos'. Unless there is a better way to deal with this, I kindly ask for an exception to be made within the pipeline.

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
* Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

* there is 1 expected error running brew audit --new-formula whatweb, . My situation is similar to https://github.com/orgs/Homebrew/discussions/2208#discussioncomment-1394078 , where it was recommended to ask the maintainers for a CI exception, otherwise i'm not sure the best way to proceed. My formula needs to install a newer Ruby version for older version of macos but without replacing replace 'depends_on' with 'uses_from_macos' which the test complains about.

github-actions · 2023-08-28T21:22:27Z

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Formula/w/whatweb.rb

SMillerDev · 2023-08-29T07:16:30Z

Formula/w/whatweb.rb

+    system "gem", "install", "bson"
+    system "gem", "install", "bson_ext"
+    system "gem", "install", "mongo"
+    system "gem", "install", "rchardet"


These should be checksummed resources, not downloaded at random like this.

added checksummed resources

@oregonpillow @SMillerDev if there's a Gemfile.lock I think it's reasonable to use that instead, otherwise: yes, I agree.

Formula/w/whatweb.rb

MikeMcQuaid · 2023-09-04T21:24:25Z

Formula/w/whatweb.rb

+      "-e", "MANPATH=#{man}"
+
+    # gem 'addressable', '~> 2.8', '>= 2.8.5'
+    resource "addressable" do


Put the resource blocks outside of def install. Other maintainers may agree but: if this has a Gemfile.lock it's using, I'm not convinced you need to use a resource for all of these instead of just using bundle install.

Previous iterations of the formulae added gems after the bundler run. That's why I suggested resources.

Yeh, I'm pretty confused as to why these gems would be manually installed like this rather than using system "bundle", "install", "--local", "--path=#{libexec}/vendor" or something (like other Ruby formulae do).

SMillerDev · 2023-09-11T11:43:36Z

Formula/w/whatweb.rb

+    system "bundle", "config", "--local", "#{libexec}/whatweb"
+    system "bundle", "update"
+    system "bundle", "install"
+    system "make", "install",


To allow bundler installs the repo should have a Gemfile.lock

MikeMcQuaid · 2023-09-11T12:09:35Z

Formula/w/whatweb.rb

+    system "gem", "install", "bundler"
+    ENV.prepend_path "PATH", buildpath/"gem_home/bin"
+    system "bundle", "config", "--local", "#{libexec}/whatweb"
+    system "bundle", "update"


Suggested change

system "bundle", "update"

We want to use the versions in Gemfile.lock here.

Thanks @MikeMcQuaid ok i will remove this, i put it there as a last ditch effort for a job i'm having trouble with.

This job keeps failing due to a missing gem addressable, which doesn't make sense to me since it's included in the Gemfile. I also tried testing the forumula on my mac computer and a Debian 10 system and they don't have this problem. I don't know if this is a CI problem or a problem for the venfor

MikeMcQuaid · 2023-09-11T15:30:22Z

Formula/w/whatweb.rb

+      "-e", "MANPATH=#{man}"
+  end
+
+  test do


Looks like https://github.com/urbanadventurer/WhatWeb/blob/master/Gemfile is missing a Gemfile.lock and that perhaps is why addressable isn't being installed as expected. I'd suggest perhaps making a PR to add one but there's been no PRs merged since 2021 so I'm wondering if this project is maintained at all any more, unfortunately.

chenrui333 · 2023-09-20T04:10:28Z

  ==> /opt/homebrew/Cellar/whatweb/0.5.5/bin/whatweb --log-json=test.json --verbose --color=never google.com
  WhatWeb is not installed and is missing dependencies.
  The following gems are missing:
   - addressable
  
  To install run the following command from the WhatWeb folder:
  'bundle install'
  
  Error: whatweb: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: 1

oregonpillow · 2023-09-20T10:09:04Z


  ==> /opt/homebrew/Cellar/whatweb/0.5.5/bin/whatweb --log-json=test.json --verbose --color=never google.com

  WhatWeb is not installed and is missing dependencies.

  The following gems are missing:

   - addressable

  

  To install run the following command from the WhatWeb folder:

  'bundle install'

  

  Error: whatweb: failed

  An exception occurred within a child process:

    Minitest::Assertion: Expected: 0

    Actual: 1

Thanks. I'm aware of this error. The problem is despite 'addressable' being listed in the gem file, bundle will not install it and I haven't figured why it's doing this, or how to fix it.

github-actions · 2023-10-11T20:24:06Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core ruby Ruby use is a significant feature of the PR or issue labels Aug 28, 2023

oregonpillow mentioned this pull request Aug 28, 2023

Installation via Brew for Mac Users urbanadventurer/WhatWeb#401

Open

SMillerDev requested changes Aug 29, 2023

View reviewed changes

oregonpillow force-pushed the whatweb-0.5.5 branch from b39f8ae to f7d45c5 Compare September 1, 2023 11:52

oregonpillow requested a review from SMillerDev September 1, 2023 12:02

oregonpillow force-pushed the whatweb-0.5.5 branch 3 times, most recently from 50acc47 to 89fd935 Compare September 1, 2023 13:11

SMillerDev requested a review from a team September 4, 2023 15:55

MikeMcQuaid reviewed Sep 4, 2023

View reviewed changes

oregonpillow force-pushed the whatweb-0.5.5 branch 4 times, most recently from 9fe88a1 to f4ca945 Compare September 11, 2023 11:42

SMillerDev reviewed Sep 11, 2023

View reviewed changes

oregonpillow force-pushed the whatweb-0.5.5 branch 3 times, most recently from d503bdb to 86b14d4 Compare September 11, 2023 12:08

MikeMcQuaid reviewed Sep 11, 2023

View reviewed changes

whatweb 0.5.5 (new formula)

8a04508

oregonpillow force-pushed the whatweb-0.5.5 branch from 86b14d4 to 8a04508 Compare September 11, 2023 14:41

MikeMcQuaid reviewed Sep 11, 2023

View reviewed changes

oregonpillow mentioned this pull request Sep 12, 2023

Add a gemfile.lock urbanadventurer/WhatWeb#403

Open

chenrui333 added the test failure CI fails while running the test-do block label Sep 20, 2023

github-actions bot added the stale No recent activity label Oct 11, 2023

github-actions bot closed this Oct 19, 2023

github-actions bot added the outdated PR was locked due to age label Nov 22, 2023

github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

whatweb 0.5.5 (new formula) #140724

whatweb 0.5.5 (new formula) #140724

oregonpillow commented Aug 28, 2023 •

edited

Loading

github-actions bot commented Aug 28, 2023

SMillerDev Aug 29, 2023

oregonpillow Sep 1, 2023

MikeMcQuaid Sep 4, 2023

MikeMcQuaid Sep 4, 2023

SMillerDev Sep 5, 2023

MikeMcQuaid Sep 5, 2023

SMillerDev Sep 11, 2023

MikeMcQuaid Sep 11, 2023

oregonpillow Sep 11, 2023

MikeMcQuaid Sep 11, 2023

chenrui333 commented Sep 20, 2023

oregonpillow commented Sep 20, 2023

github-actions bot commented Oct 11, 2023

whatweb 0.5.5 (new formula) #140724

whatweb 0.5.5 (new formula) #140724

Conversation

oregonpillow commented Aug 28, 2023 • edited Loading

github-actions bot commented Aug 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenrui333 commented Sep 20, 2023

oregonpillow commented Sep 20, 2023

github-actions bot commented Oct 11, 2023

oregonpillow commented Aug 28, 2023 •

edited

Loading