openjdk@17 17.0.10 #160094

Porkepix · 2024-01-16T23:06:20Z

Created by brew bump

Created with brew bump-formula-pr.

resource blocks have been checked for updates.

github-actions · 2024-01-19T00:02:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

openjdk@17: update boostrap jdk Signed-off-by: Rui Chen <[email protected]>

chenrui333 · 2024-01-19T22:24:58Z

  checking for version string... 17.0.10+0
  configure: error: The path of BOOT_JDK_ARG, which resolves as "/private/tmp/openjdkA17-20240119-5379-qyga7x/jdk17u-jdk-17.0.10-ga/boot-jdk/Contents/Home", is not found.
  /private/tmp/openjdkA17-20240119-5379-qyga7x/jdk17u-jdk-17.0.10-ga/build/.configure-support/generated-configure.sh: line 84: 5: Bad file descriptor

Signed-off-by: Rui Chen <[email protected]>

cho-m · 2024-01-26T16:46:41Z

Formula/o/[email protected]

-        url "https://download.java.net/java/GA/jdk17.0.2/dfd4a8d0985749f896bed50d7138ee7f/8/GPL/openjdk-17.0.2_macos-aarch64_bin.tar.gz"
-        sha256 "602d7de72526368bb3f80d95c4427696ea639d2e0cc40455f53ff0bbb18c27c8"
+        url "https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-macosx_aarch64.tar.gz"
+        sha256 "d6837676e55b97772b6512e253fdaf8ab282bb216c0f8366b6c5905cd02b5056"


Was there a specific issue that required updating JDK on ARM?

I sometimes update these to use bump version minus one to build as it seems generally more appropriate.
Here it's @chenrui333 's doing to move to these to Zulu and I don't know why.
Same for when on another bump resource was updated to build from binary release of the exact same version: generally you want to build with version n-1, so I didn't knew why use the same.

Same major version may be worth it here as there is no OpenJDK 16 ARM release. It would allow avoiding a 3rd party JDK. For older OpenJDK, it may depend on if there are any required fixes, e.g. OpenJDK 10 is no longer supported so may not get all backports (Mainly issue for new platforms like Apple ARM).

Unless there is a required fix, I think we can stick to OpenJDK's binaries for bootstrap on newer OpenJDK formulae (openjdk@17 and openjdk).

I meant for patch versions, like using 17.0.1 to build 17.0.2 (or latest 17.x.y for 18.0.0).

For OpenJDK, n-1 refers to previous major version and is the standard choice of boot JDK.

Changing patch release usually has minor/no impact and OpenJDK doesn't provide them after a certain point. They point to Temurin releases instead https://wiki.openjdk.org/display/JDKUpdates/JDK+17u#JDK17u-Downloads

just a bootstrap jdk, it is fine to use whatever latest

just a bootstrap jdk, it is fine to use whatever latest

The main thing is we only resort to Zulu as a last resort (e.g. OpenJDK7 doesn't exist and OpenJDK11 doesn't provide ARM release).

Anyway, I think this should be reverted unless there is a specific issue. And if there is a specific issue, it should be included in the comment.

For example, the reason we use Zulu on openjdk@8:

homebrew-core/Formula/o/[email protected]

Lines 50 to 52 in bceb694

# Oracle doesn't serve JDK 7 downloads anymore, so we use Zulu JDK 7 for bootstrapping.

# https://www.azul.com/downloads/?version=java-7-lts&package=jdk

resource "boot-jdk" do

We definitely should not use a random non-open boot JDK here.

SMillerDev · 2024-01-29T08:08:52Z

Formula/o/[email protected]

-        url "https://download.java.net/java/GA/jdk17.0.2/dfd4a8d0985749f896bed50d7138ee7f/8/GPL/openjdk-17.0.2_macos-aarch64_bin.tar.gz"
-        sha256 "602d7de72526368bb3f80d95c4427696ea639d2e0cc40455f53ff0bbb18c27c8"
+        url "https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-macosx_aarch64.tar.gz"
+        sha256 "d6837676e55b97772b6512e253fdaf8ab282bb216c0f8366b6c5905cd02b5056"


We definitely should not use a random non-open boot JDK here.

github-actions · 2024-02-23T00:02:14Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

Porkepix · 2024-02-26T04:05:08Z

Formula/o/[email protected]

@@ -77,7 +78,7 @@ class OpenjdkAT17 < Formula
  def install
    boot_jdk = buildpath/"boot-jdk"
    resource("boot-jdk").stage boot_jdk
-    boot_jdk /= "Contents/Home" if OS.mac?
+    boot_jdk /= "Contents/Home" if OS.mac? && !Hardware::CPU.arm?


@chenrui333 I don't know what was the purpose of this change, but another PR was merged without, in case this was important to get.

github-actions bot added legacy Relates to a versioned @ formula bump-formula-pr PR was created using `brew bump-formula-pr` labels Jan 16, 2024

github-actions bot added the stale No recent activity label Jan 19, 2024

chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Jan 19, 2024

openjdk@17 17.0.10

feadf4f

openjdk@17: update boostrap jdk Signed-off-by: Rui Chen <[email protected]>

chenrui333 force-pushed the [email protected] branch from a4d22ad to feadf4f Compare January 19, 2024 22:09

chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Jan 19, 2024

openjdk@17: update build

57a9812

Signed-off-by: Rui Chen <[email protected]>

github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jan 19, 2024

bevanjkay requested a review from cho-m January 23, 2024 23:02

cho-m reviewed Jan 26, 2024

View reviewed changes

cho-m mentioned this pull request Jan 27, 2024

jmeter crahes when using openjdk bundled with the brew formula #150824

Closed

4 tasks

SMillerDev requested changes Jan 29, 2024

View reviewed changes

Porkepix mentioned this pull request Feb 17, 2024

openjdk@17 17.0.10 #163020

Closed

1 task

SMillerDev removed the in progress Stale bot should stay away label Feb 20, 2024

github-actions bot added the stale No recent activity label Feb 23, 2024

github-actions bot closed this Feb 24, 2024

Porkepix commented Feb 26, 2024

View reviewed changes

github-actions bot added the outdated PR was locked due to age label Mar 28, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openjdk@17 17.0.10 #160094

openjdk@17 17.0.10 #160094

Porkepix commented Jan 16, 2024 •

edited by chenrui333

Loading

github-actions bot commented Jan 19, 2024

chenrui333 commented Jan 19, 2024

cho-m Jan 26, 2024

Porkepix Jan 26, 2024 •

edited

Loading

cho-m Jan 26, 2024

Porkepix Jan 26, 2024

cho-m Jan 26, 2024 •

edited

Loading

chenrui333 Jan 27, 2024

cho-m Jan 27, 2024

cho-m Jan 27, 2024

SMillerDev Jan 29, 2024

SMillerDev Jan 29, 2024

github-actions bot commented Feb 23, 2024

Porkepix Feb 26, 2024

	# Oracle doesn't serve JDK 7 downloads anymore, so we use Zulu JDK 7 for bootstrapping.
	# https://www.azul.com/downloads/?version=java-7-lts&package=jdk
	resource "boot-jdk" do

openjdk@17 17.0.10 #160094

openjdk@17 17.0.10 #160094

Conversation

Porkepix commented Jan 16, 2024 • edited by chenrui333 Loading

github-actions bot commented Jan 19, 2024

chenrui333 commented Jan 19, 2024

Choose a reason for hiding this comment

Porkepix Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cho-m Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024

Choose a reason for hiding this comment

Porkepix commented Jan 16, 2024 •

edited by chenrui333

Loading

Porkepix Jan 26, 2024 •

edited

Loading

cho-m Jan 26, 2024 •

edited

Loading