-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk@17 17.0.10 #160094
openjdk@17 17.0.10 #160094
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
openjdk@17: update boostrap jdk Signed-off-by: Rui Chen <[email protected]>
a4d22ad
to
feadf4f
Compare
|
Signed-off-by: Rui Chen <[email protected]>
url "https://download.java.net/java/GA/jdk17.0.2/dfd4a8d0985749f896bed50d7138ee7f/8/GPL/openjdk-17.0.2_macos-aarch64_bin.tar.gz" | ||
sha256 "602d7de72526368bb3f80d95c4427696ea639d2e0cc40455f53ff0bbb18c27c8" | ||
url "https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-macosx_aarch64.tar.gz" | ||
sha256 "d6837676e55b97772b6512e253fdaf8ab282bb216c0f8366b6c5905cd02b5056" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a specific issue that required updating JDK on ARM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sometimes update these to use bump version minus one
to build as it seems generally more appropriate.
Here it's @chenrui333 's doing to move to these to Zulu and I don't know why.
Same for when on another bump resource was updated to build from binary release of the exact same version: generally you want to build with version n-1
, so I didn't knew why use the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same major version may be worth it here as there is no OpenJDK 16 ARM release. It would allow avoiding a 3rd party JDK. For older OpenJDK, it may depend on if there are any required fixes, e.g. OpenJDK 10 is no longer supported so may not get all backports (Mainly issue for new platforms like Apple ARM).
Unless there is a required fix, I think we can stick to OpenJDK's binaries for bootstrap on newer OpenJDK formulae (openjdk@17
and openjdk
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant for patch versions, like using 17.0.1 to build 17.0.2 (or latest 17.x.y for 18.0.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For OpenJDK, n-1
refers to previous major version and is the standard choice of boot JDK.
Changing patch release usually has minor/no impact and OpenJDK doesn't provide them after a certain point. They point to Temurin releases instead https://wiki.openjdk.org/display/JDKUpdates/JDK+17u#JDK17u-Downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a bootstrap jdk, it is fine to use whatever latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a bootstrap jdk, it is fine to use whatever latest
The main thing is we only resort to Zulu as a last resort (e.g. OpenJDK7 doesn't exist and OpenJDK11 doesn't provide ARM release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I think this should be reverted unless there is a specific issue. And if there is a specific issue, it should be included in the comment.
For example, the reason we use Zulu on openjdk@8
:
homebrew-core/Formula/o/[email protected]
Lines 50 to 52 in bceb694
# Oracle doesn't serve JDK 7 downloads anymore, so we use Zulu JDK 7 for bootstrapping. | |
# https://www.azul.com/downloads/?version=java-7-lts&package=jdk | |
resource "boot-jdk" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should not use a random non-open boot JDK here.
url "https://download.java.net/java/GA/jdk17.0.2/dfd4a8d0985749f896bed50d7138ee7f/8/GPL/openjdk-17.0.2_macos-aarch64_bin.tar.gz" | ||
sha256 "602d7de72526368bb3f80d95c4427696ea639d2e0cc40455f53ff0bbb18c27c8" | ||
url "https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-macosx_aarch64.tar.gz" | ||
sha256 "d6837676e55b97772b6512e253fdaf8ab282bb216c0f8366b6c5905cd02b5056" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should not use a random non-open boot JDK here.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
@@ -77,7 +78,7 @@ class OpenjdkAT17 < Formula | |||
def install | |||
boot_jdk = buildpath/"boot-jdk" | |||
resource("boot-jdk").stage boot_jdk | |||
boot_jdk /= "Contents/Home" if OS.mac? | |||
boot_jdk /= "Contents/Home" if OS.mac? && !Hardware::CPU.arm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenrui333 I don't know what was the purpose of this change, but another PR was merged without, in case this was important to get.
Created by
brew bump
Created with
brew bump-formula-pr
.resource
blocks have been checked for updates.