-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
localai 2.18.1 (new formula) #172734
base: master
Are you sure you want to change the base?
localai 2.18.1 (new formula) #172734
Conversation
9b5e255
to
20c5685
Compare
still some test failure
|
Would be great if the package was update to use 2.16.0 as it supports new features such as function calling and also a single binary release so doesn't require compilation. Though I added to explicitly run |
Nothing should be statically linked in Homebrew formulae. |
@chenrui333 I don't really have such systems (macos 14 x86_64) to debug, I find it interesting that it works on macos 12 with the same arch, do you think it's a matter of increasing the delay a bit more? Or worst case scenario, can I say it's just arm64 available, since it's the only OS I myself can test? |
@prabirshrestha I'd rather have this merged first than introducing even more changes, as soon as it is merged we will get a version bump and we can see if there's much needed to change or if it works as is. But maybe version 2.16 passes the tests and then it's worth doing already 🤷 |
39d781b
to
52e7583
Compare
@carlocab do you know why I encounter this issue on the runners but not on local?
|
This introduces the formula for LocalAI https://localai.io/ the free, Open Source OpenAI alternative. Self-hosted, community-driven and local-first
Couldn't figure out where the issue comes from, but thankfully it was possible to remove one of the backends in LocalAI and this made it work. |
@chenrui333 tests are green now |
@SMillerDev would you have some time to review this? |
# We exclude gpt4all backend because it is causing an issue between | ||
# CMAKE_OSX_ARCHITECTURES and the CXX compiler targets architectures. Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have issue tracking this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenrui333 issue in which project you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess whatever project that we can followup on this :) I was thinking localai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not an issue of LocalAI itself, the gpt4all backend can only be built one arch at a time, so passing the multi-arch will always break. I don't think this should block this PR from being merged though. I'm already working for a cleaner way to exclude backends in LocalAI, which I can use once the next release is out, but it would be very helpful if we could have the formula already merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why does it need to pass multiarch? Brew also only builds everything for a single arch at a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SMillerDev good question, I'm not sure why the runner has CMAKE_OSX_ARCHITECTURES
set to "arm64;x86_64" which is why this error pops up
CMake Error at /opt/homebrew/Cellar/cmake/3.30.0/share/cmake/Modules/CMakeDetermineCompilerABI.cmake:129 (message):
The CXX compiler targets architectures:
"arm64"
but CMAKE_OSX_ARCHITECTURES is
"arm64;x86_64"
sorry not a macOS expert here, so cannot really tell if this is expected in general or just on the runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried in different ways to set CMAKE_OSX_ARCHITECTURES
just the currently running arch, but that didn't work. I think that is related to how the shell out in ruby does the passing of the environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not supposed to be an environment variable, how about setting -DCMAKE_OSX_ARCHITECTURES=#{Hardware::CPU.arch}
as a CMake arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauromorales can we try out the cmake arg route?
@carlocab @chenrui333 @SMillerDev tests are now passing, would it be possible to remove the "test failure" tag? |
Is there anything pending on this formula? I would love to help on this to take this to completion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on response to #172734 (comment)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hello @carloca @chenrui333 @SMillerDev The tests are passing for this PR. Awaiting for you inputs. |
See #172734 (review) |
Seems like gpt4all backend is getting deprecated in LocalAI so probably that comment should be removed instead. https://github.com/mudler/LocalAI/releases/tag/v2.20.1 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
trying to build the latest 2.20.1 release, but seeing some of the following build errors:
|
|
Adds formula for LocalAI https://localai.io/
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?