xerces-c 3.2.0 #17371

rleigh-codelibre · 2017-08-29T11:31:25Z

[Y] Have you followed the guidelines for contributing?
[Y] Have you checked that there aren't other open pull requests for the same formula update/change?
[Y] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
[Y] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Note, this release switches to cmake, and this automatically enables the use of char16_t for unicode strings in place of uint16_t. This means you can use u"string" directly which is a nice usability gain, but it does mean that all packages using xerces-c must compile with C++11 enabled. If this proves to be a problem, we can explicitly disable it until Xcode enables it by default. I've patched xalan-c (https://issues.apache.org/jira/browse/XALANC-773).

ilovezfs · 2017-08-29T11:32:43Z

Formula/xalan-c.rb

@@ -25,6 +26,7 @@ class XalanC < Formula

  def install
    ENV.deparallelize # See https://issues.apache.org/jira/browse/XALANC-696
+    ENV["CXXFLAGS"] = "-std=c++11"


You'll want to use

needs :cxx11

and

ENV.cxx11

instead.

ilovezfs · 2017-08-29T11:42:33Z

Formula/xalan-c.rb

    ENV.deparallelize # See https://issues.apache.org/jira/browse/XALANC-696
+    ENV["CXXFLAGS"] = "-std=c++11"


this shouldn't be needed now that you've added ENV.cxx11.

D'oh. I'll push that in just a second.

rleigh-codelibre · 2017-08-29T15:13:19Z

@ilovezfs I've updated the revision of the dependent packages and added C++11 support there, but it's not building them in the CI testing AFAICT. Is something else missing? The errors when testing the bottled version are because the soname changed.

ilovezfs · 2017-08-31T09:58:13Z

@rleigh-codelibre the ones that are failing need to be revision bumped.

ilovezfs · 2017-09-03T16:52:01Z

@rleigh-codelibre I have pushed the revision bumps.

rleigh-codelibre · 2017-09-03T17:34:31Z

@ilovezfs Thanks. Some of them might need C++11 enabling. And some like zquilla need some patches to fix incompatibilities in the code. I'm working my way through these in the BSD ports tree, and I'll carry the patches over to homebrew once I've tested them.

rleigh-codelibre · 2017-09-04T12:32:40Z

@ilovezfs I've patched all the necessary packages and filed bug reports upstream wherever possible. The remaining errors are not in this PR but are warnings about existing problems:

11:25:34 ==> FAILED
11:25:34 Error: 1 problem in 1 formula
11:25:34 xml-tooling-c:
11:25:34   * Dependency curl should not use option with-openssl

11:54:55 ==> FAILED
11:54:55 Error: 1 problem in 1 formula
11:54:55 enigma:
11:54:55   * Dependency sdl_mixer should not use option with-libmikmod


12:06:16 ==> FAILED
12:06:16 Error: 1 problem in 1 formula
12:06:16 shibboleth-sp:
12:06:16   * Dependency curl should not use option with-openssl

Should these problems be addressed in this PR? I'm not exactly sure what the fixes are for these audit violations.

ilovezfs · 2017-09-04T12:34:35Z

Should these problems be addressed in this PR? I'm not exactly sure what the fixes are for these audit violations.

Nope. They're being tracked in #13133.

I've patched all the necessary packages and filed bug reports upstream wherever possible.

Please submit PR(s) to https://github.com/Homebrew/formula-patches so they don't have to live in the formulae themselves.

rleigh-codelibre · 2017-09-04T13:30:11Z

@ilovezfs I've opened Homebrew/formula-patches#175 . I'll update this PR once that one is merged?

JCount · 2017-09-10T18:23:22Z

@rleigh-codelibre I've merged all the patches, and I apologize for pinging you repeatedly whilst doing so. However, you should be set to move this PR forward. Thank you for your patience.

ilovezfs · 2017-09-11T12:42:32Z

@rleigh-codelibre ping. Also note that this PR should be 1 commit per formula.

rleigh-codelibre · 2017-09-16T20:14:07Z

Thanks. I'm away for the next week, so I'll update this in 8 days.

ilovezfs · 2017-09-17T17:42:43Z

@BrewTestBot test this please

ilovezfs · 2017-09-17T18:21:19Z

@BrewTestBot test this please

dunn · 2017-09-19T16:47:25Z

Looks like this needs to be rebased.

ilovezfs · 2017-09-19T16:50:06Z

Right. But rleigh-codelibre is away for a few days, so …

rleigh-codelibre · 2017-09-25T15:43:16Z

@JCount @ilovezfs Sorry for the delay; I've updated the branch to use the formula-patches and split up the commits, and rebased the lot onto current master. Hope that's all OK.

rleigh-codelibre · 2017-09-25T17:22:50Z

There's one audit failure which seems to be in shibboleth-sp related to curl/openssl, unrelated to this PR.

ilovezfs · 2017-09-27T09:50:05Z

@BrewTestBot test this please

ilovezfs · 2017-09-27T22:42:17Z

@gvenzl do you have any idea who we should report the patch for dbxml to? (see https://raw.githubusercontent.com/Homebrew/formula-patches/master/dbxml/c%2B%2B11.patch)

ilovezfs · 2017-09-30T06:02:29Z

@BrewTestBot test this please

ilovezfs · 2017-10-07T05:25:56Z

@BrewTestBot test this please

ilovezfs · 2017-10-07T07:39:34Z

Thanks @rleigh-codelibre! You're awesome :)

❇️ 🎉 🎊

ilovezfs reviewed Aug 29, 2017

View reviewed changes

ilovezfs added revision bumps needed Reverse dependencies need to have their revision incremented in the same PR and removed revision bumps needed Reverse dependencies need to have their revision incremented in the same PR labels Aug 31, 2017

rleigh-codelibre mentioned this pull request Sep 4, 2017

xalan-c 3.2.0: Patches for new release and C++11 compile fixes Homebrew/formula-patches#175

Closed

Philat mentioned this pull request Sep 6, 2017

CMake bootstrap error Homebrew/brew#3131

Closed

SConaway mentioned this pull request Sep 7, 2017

OpenSSL seems to fail to build on 10.13db9 17A360a #17732

Closed

5 tasks

Roger Leigh added 9 commits September 25, 2017 16:06

xerces-c 3.2.0

98e6ca2

blahtexml: Revision for xerces-c (build with C++11)

c0d5104

dbxml: Revision for xerces-c (build with C++11)

018b7ce

enigma: Revision for xerces-c (build with C++11)

54f5cf2

opensaml: Revision for xerces-c (build with C++11)

d482a66

pktanon: Revision for xerces-c (build with C++11)

f1242da

shibboleth-sp: Revision for xerces-c (build with C++11)

531e185

xalan-c: Revision for xerces-c (build with C++11)

6b5c36c

xml-security-c: Revision for xerces-c (build with C++11)

9db45c8

Roger Leigh added 4 commits September 25, 2017 16:11

xml-tooling-c: Revision for xerces-c (build with C++11)

89e2f35

xqilla: Revision for xerces-c (build with C++11)

1c5cb42

xsd: Revision for xerces-c (build with C++11)

f09c96e

zorba: Revision for xerces-c (build with C++11)

4288f87

ilovezfs closed this in a593e3d Oct 7, 2017

rleigh-codelibre deleted the xerces-c-3.2.0 branch October 7, 2017 08:25

ilovezfs mentioned this pull request Apr 5, 2018

Remove c++11 compile flags so that xerces-c can be used on projects t… #26217

Closed

4 tasks

Homebrew locked and limited conversation to collaborators May 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xerces-c 3.2.0 #17371

xerces-c 3.2.0 #17371

rleigh-codelibre commented Aug 29, 2017 •

edited

Loading

ilovezfs Aug 29, 2017

ilovezfs Aug 29, 2017

rleigh-codelibre Aug 29, 2017

rleigh-codelibre commented Aug 29, 2017

ilovezfs commented Aug 31, 2017

ilovezfs commented Sep 3, 2017

rleigh-codelibre commented Sep 3, 2017

rleigh-codelibre commented Sep 4, 2017

ilovezfs commented Sep 4, 2017

rleigh-codelibre commented Sep 4, 2017

JCount commented Sep 10, 2017

ilovezfs commented Sep 11, 2017

rleigh-codelibre commented Sep 16, 2017

ilovezfs commented Sep 17, 2017

ilovezfs commented Sep 17, 2017

dunn commented Sep 19, 2017

ilovezfs commented Sep 19, 2017

rleigh-codelibre commented Sep 25, 2017 •

edited

Loading

rleigh-codelibre commented Sep 25, 2017

ilovezfs commented Sep 27, 2017

ilovezfs commented Sep 27, 2017

ilovezfs commented Sep 30, 2017

ilovezfs commented Oct 7, 2017

ilovezfs commented Oct 7, 2017

		ENV.deparallelize # See https://issues.apache.org/jira/browse/XALANC-696
		ENV["CXXFLAGS"] = "-std=c++11"

xerces-c 3.2.0 #17371

xerces-c 3.2.0 #17371

Conversation

rleigh-codelibre commented Aug 29, 2017 • edited Loading

ilovezfs Aug 29, 2017

Choose a reason for hiding this comment

ilovezfs Aug 29, 2017

Choose a reason for hiding this comment

rleigh-codelibre Aug 29, 2017

Choose a reason for hiding this comment

rleigh-codelibre commented Aug 29, 2017

ilovezfs commented Aug 31, 2017

ilovezfs commented Sep 3, 2017

rleigh-codelibre commented Sep 3, 2017

rleigh-codelibre commented Sep 4, 2017

ilovezfs commented Sep 4, 2017

rleigh-codelibre commented Sep 4, 2017

JCount commented Sep 10, 2017

ilovezfs commented Sep 11, 2017

rleigh-codelibre commented Sep 16, 2017

ilovezfs commented Sep 17, 2017

ilovezfs commented Sep 17, 2017

dunn commented Sep 19, 2017

ilovezfs commented Sep 19, 2017

rleigh-codelibre commented Sep 25, 2017 • edited Loading

rleigh-codelibre commented Sep 25, 2017

ilovezfs commented Sep 27, 2017

ilovezfs commented Sep 27, 2017

ilovezfs commented Sep 30, 2017

ilovezfs commented Oct 7, 2017

ilovezfs commented Oct 7, 2017

rleigh-codelibre commented Aug 29, 2017 •

edited

Loading

rleigh-codelibre commented Sep 25, 2017 •

edited

Loading