Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build dependency with option from ccache #19447

Closed
wants to merge 1 commit into from
Closed

Remove build dependency with option from ccache #19447

wants to merge 1 commit into from

Conversation

Git-Jiro
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove build dependency on asciidoc because of audit change: #13133

Is this the correct way to handle this for ccache?

@DomT4
Copy link
Member

DomT4 commented Oct 15, 2017

Unfortunately as-is this breaks the --HEAD build:

==> make install
asciidoc -a revnumber=unknown -d manpage -b docbook MANUAL.txt
make: asciidoc: No such file or directory
make: *** [MANUAL.xml] Error 1

@ilovezfs
Copy link
Contributor

Sorry, passing on this, as this will need to be addressed at some point in a way that does not break the build but thanks nonetheless.

@ilovezfs ilovezfs closed this Oct 15, 2017
@Git-Jiro
Copy link
Contributor Author

OK, no problem. I will make another PR when I have a solution that works with --HEAD as well.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants