nest: migrate to homebrew/core #24908
Conversation
|
Failure is because of |
fxcoudert
added
new formula
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Is there something blocking this PR? |
| url "https://github.com/nest/nest-simulator/archive/v2.14.0.tar.gz" | ||
| sha256 "afaf7d53c2d5305fac1257759cc0ea6d62c3cebf7d5cc4a07d4739af4dbb9caf" | ||
|
|
||
| bottle do |
| end | ||
|
|
||
| # Add patches for matplotlib removal in upstream: | ||
| patch do |
There was a problem hiding this comment.
😢 patches… can upstream make a new release?
| sha256 "69e4d642555a7abefc65dc287d48715ffb42faac72e1ff3dfb880fda58564045" | ||
| end | ||
|
|
||
| option "with-python", "Build Python3 bindings (PyNEST) instead of Python2 bindings." |
There was a problem hiding this comment.
Let's choose a python version, and build it with no options. I recommend moving to python3.
| # core only supports macOS and https://docs.brew.sh/Python-for-Formula-Authors.html#bindings | ||
| depends_on "python" => :optional | ||
|
|
||
| resource "Cython" do |
There was a problem hiding this comment.
We have formulas for python, numpy, scipy. Can we use those?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
There is a release planned: https://github.com/nest/nest-simulator/milestone/5 I am waiting for that to happen, then the patches are gone. |
|
Thanks @tammoippen, I am going to close this pull request for now, but we'll be very happy to consider an updated PR that addresses the review comments and uses the next version of nest! |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Reopening #21561, as the upstream PR (nest/nest-simulator#872) is now merged. (Sorry for the inconvenience of another PR - I messed up my fork.)